Skip to content

Harden local summary failure feedback#1121

Merged
r3dbars merged 1 commit into
mainfrom
codex/gemma-beta-summary-feedback
Jun 15, 2026
Merged

Harden local summary failure feedback#1121
r3dbars merged 1 commit into
mainfrom
codex/gemma-beta-summary-feedback

Conversation

@r3dbars

@r3dbars r3dbars commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Why

Justin found the local Gemma summary beta confusing before the 1.1.47 gate: setup belongs on Beta, and running a meeting summary needs obvious progress/failure feedback.

Current main already has the Beta toggle/provider/prep flow and row-level running state. The remaining low-risk gap was failure: a summary error only surfaced through a transient generic alert, then the Home row went back to normal.

Product Impact

  • Affects: meetings, settings, beta local AI summaries
  • Lane: meeting reliability
  • Why this matters: a failed local summary should be visible and retryable without making the user guess whether Gemma is still running, failed, or changed the transcript.

What changed

  • Split Home local-summary notices into saved vs failed states.
  • Saved summaries keep the existing success card and auto-dismiss behavior.
  • Failed summaries now show a persistent warning activity card with AI summary failed, Needs retry, clear failure detail, and a Retry summary action.
  • Failure copy says nothing was changed, so users know the meeting Markdown was not silently rewritten.
  • Retry runs the same local summary path again by transcript URL/title.
  • Added fast tests for saved notice auto-dismiss and failed notice retry/persistence copy.

Existing state checked

How I checked it

  • scripts/dev/agent-preflight.sh
  • git diff --check
  • bash run-tests.sh --filter HomeMeetingSummaryBetaPresentationPolicyTests — 25/25 passed
  • bash build-deps.sh --force — required after build.sh reported stale/missing deps
  • bash build.sh --no-open — passed, including launch smoke and performance budget
  • bash run-tests.sh — 5304/5304 passed
  • bash scripts/ops/run-local-summary-fixture.sh — deterministic direct + chunked local summary fixture passed
  • codex review --uncommitted — clean; no actionable correctness findings. The review also reran bash run-tests.sh and bash build.sh --no-open successfully.

Manual proof still needed

  • Real Beta page flow on Justin's Mac: toggle on, prepare Gemma, cancel/retry setup, and confirm setup copy feels clear.
  • Real first-run Gemma download / partial-download restart behavior.
  • Real meeting summary run on a saved meeting, including corrupt or missing local model cache behavior.
  • Visual/manual check that the failure card and retry action feel obvious in the actual Settings Home UI.

Risk Review

  • Privacy/local-first reviewed: no off-device payload change, no transcript/audio/title/path logging added.
  • Storage reviewed: no storage-path or model-cache mutation change.
  • Release/update reviewed: no version, appcast, packaging, Sparkle, or Homebrew changes.
  • Manual proof boundary preserved: automation proves UI state and deterministic summary fixture shape, not real Gemma quality/download behavior.

@r3dbars r3dbars marked this pull request as ready for review June 15, 2026 15:26
@r3dbars r3dbars merged commit 93bbb1d into main Jun 15, 2026
3 checks passed
@r3dbars r3dbars deleted the codex/gemma-beta-summary-feedback branch June 15, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant