Harden local summary failure feedback#1121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Justin found the local Gemma summary beta confusing before the 1.1.47 gate: setup belongs on Beta, and running a meeting summary needs obvious progress/failure feedback.
Current
mainalready has the Beta toggle/provider/prep flow and row-level running state. The remaining low-risk gap was failure: a summary error only surfaced through a transient generic alert, then the Home row went back to normal.Product Impact
meetings,settings,beta local AI summariesmeeting reliabilityWhat changed
AI summary failed,Needs retry, clear failure detail, and aRetry summaryaction.Existing state checked
origin/main; branch starts atd1dce554.How I checked it
scripts/dev/agent-preflight.shgit diff --checkbash run-tests.sh --filter HomeMeetingSummaryBetaPresentationPolicyTests— 25/25 passedbash build-deps.sh --force— required afterbuild.shreported stale/missing depsbash build.sh --no-open— passed, including launch smoke and performance budgetbash run-tests.sh— 5304/5304 passedbash scripts/ops/run-local-summary-fixture.sh— deterministic direct + chunked local summary fixture passedcodex review --uncommitted— clean; no actionable correctness findings. The review also reranbash run-tests.shandbash build.sh --no-opensuccessfully.Manual proof still needed
Risk Review