Skip to content

[codex] Fix Home summary notice dismissal#1128

Merged
r3dbars merged 1 commit into
mainfrom
codex/fix-home-summary-notice
Jun 15, 2026
Merged

[codex] Fix Home summary notice dismissal#1128
r3dbars merged 1 commit into
mainfrom
codex/fix-home-summary-notice

Conversation

@r3dbars

@r3dbars r3dbars commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • tighten the Home local-summary notice dismissal path so the timer resolves the next notice state through the shared policy
  • extend the focused Home summary notice test to prove the scheduled notice clears while an older timer leaves a newer notice visible

Repro signal

The June 8 self-sent Transcripted Feedback email showed meeting.local_meeting_summary_completed with chunk_count=1, while the green AI summary saved Home notice stayed on screen. That points at the Home notice lifecycle after completion, not the Gemma generation path itself.

Nearby follow-up

The same report also says Gemma setup can show ready while Home remains in Generating AI summary for a long time. I kept this PR scoped to the stuck saved notice; that slower generating state should be handled separately.

Verification

  • bash run-tests.sh --filter HomeMeetingSummaryBetaPresentationPolicyTests
  • bash build-deps.sh --force
  • bash build.sh --no-open
  • bash run-tests.sh

@r3dbars r3dbars marked this pull request as ready for review June 15, 2026 15:26
@r3dbars r3dbars merged commit 644462c into main Jun 15, 2026
3 checks passed
@r3dbars r3dbars deleted the codex/fix-home-summary-notice branch June 15, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant