Open
Conversation
r3kste
requested changes
Feb 3, 2026
Owner
r3kste
left a comment
There was a problem hiding this comment.
- You need to figure/clarify how to handle cases with multiple subplots (also mixture of 3d and 2d). There are two solutions I could think of:
- Add all three entries for all 3d subplots. So if a figure has two 3d axes, then the hammburger menu would have 6 entries
- Use just three entries, which controls all axes.
Both of the above are not ideal. I feel like the context menu was much better suited, so you might have to try to convince them, by mentioning this issue.
- I also left a review comment about a possible way to manage entries without introducing
view_initinbackend_bases. Check that out, but is currently of lower priority than the above point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist