Skip to content

Hamburger Menu#10

Open
AdwaithBatchu wants to merge 1 commit intor3kste:mainfrom
AdwaithBatchu:Hamburger-Menu
Open

Hamburger Menu#10
AdwaithBatchu wants to merge 1 commit intor3kste:mainfrom
AdwaithBatchu:Hamburger-Menu

Conversation

@AdwaithBatchu
Copy link
Collaborator

PR summary

PR checklist

Copy link
Owner

@r3kste r3kste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You need to figure/clarify how to handle cases with multiple subplots (also mixture of 3d and 2d). There are two solutions I could think of:
  • Add all three entries for all 3d subplots. So if a figure has two 3d axes, then the hammburger menu would have 6 entries
  • Use just three entries, which controls all axes.

Both of the above are not ideal. I feel like the context menu was much better suited, so you might have to try to convince them, by mentioning this issue.

  1. I also left a review comment about a possible way to manage entries without introducing view_init in backend_bases. Check that out, but is currently of lower priority than the above point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants