Add rss trigger#18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c822f183df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| include Concerns::ChangeDetecting | ||
|
|
||
| validates :url, presence: true | ||
| validates_with Validators::Url, url_field: :url |
There was a problem hiding this comment.
validates_with Validators::Url, url_field: :url wires R3x::Validators::Url into ActiveModel, but that class is a utility with only .validate! and does not implement the ActiveModel::Validator interface (validate(record) with option-aware initialization). In practice this causes RSS trigger validation/loading to fail when trigger :rss is declared, so workflows using this new trigger cannot be registered reliably.
Useful? React with 👍 / 👎.
| validates :url, presence: true | ||
| validates_with Validators::Url, url_field: :url |
There was a problem hiding this comment.
This trigger is marked CronSchedulable and stores cron in options, but it never validates cron presence or format. That lets invalid/blank cron values pass DSL validation and only fail later when recurring tasks are created from trigger.cron, which breaks the expected fail-fast configuration behavior for schedulable triggers.
Useful? React with 👍 / 👎.
zewelor
force-pushed
the
main
branch
3 times, most recently
from
8561c04 to
801b7e6
Compare
zewelor
force-pushed
the
main
branch
7 times, most recently
from
c47ea07 to
ef8244c
Compare
1 participant
No description provided.