Adds star rating functionality to the dial controls and fixes several overlay display bugs.#5
Closed
DreadHeadHippy wants to merge 2 commits into
Closed
Adds star rating functionality to the dial controls and fixes several overlay display bugs.#5DreadHeadHippy wants to merge 2 commits into
DreadHeadHippy wants to merge 2 commits into
Conversation
Features: - Star rating control via dial with half-star and full-star modes - Debounced rating saves (2-second idle timer) - Real-time star display with Unicode characters (★☆⯨) - Success/error feedback on Stream Deck display - Rating persistence to Plex server Bug Fixes: - Fixed overlay reversion issues (volume, next/prev, rating) - Corrected layout geometry to prevent element overlap - Added protection against timeline poll overwrites Improvements: - Enhanced user feedback with on-device error messages - Updated documentation (CHANGELOG, README) - Version bumped to 1.2.0 across all files
- Improve credential handling in network requests - Add URL validation for user-provided endpoints - Strengthen connection security requirements - Update error handling and user feedback
Author
|
Closing this PR in favor of a more comprehensive update that includes these changes plus important security improvements. The new PR (#6) includes:
This consolidation makes it easier to review and merge all improvements together while ensuring users get the security fixes alongside the new features. Thank you for your patience! The new PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Star Rating Feature
Bug Fixes
Documentation
Testing
Tested on Stream Deck+ with:
Technical Notes
/:/rateendpointInstallation
com.rackemrack.ampdeck.streamDeckPluginfrom the Releases pageThat's it. Stream Deck handles the rest.
Happy to make any adjustments if needed! 🤙