[AMD] fix: support Python 3.10#12
Open
XinyuJiangCMU wants to merge 2 commits into
Open
Conversation
The package targets py3.10 already (ruff target-version = py310, and the classifiers list Python :: 3.10), but requires-python pins >=3.12, which blocks installation on a Python 3.10 base. Relax the lower bound to 3.10. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
typing.override is Python 3.12+; on 3.10 it raises ImportError when these builder modules are imported. typing_extensions (already a dependency) provides an identical override decorator and re-exports the stdlib one on 3.12+, so NV behavior is unchanged. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
guapisolo
reviewed
Jun 18, 2026
| from typing import Any, Callable, ClassVar, Literal, override | ||
| from typing import Any, Callable, ClassVar, Literal | ||
|
|
||
| from typing_extensions import override |
Author
There was a problem hiding this comment.
Tested on Python 3.12. It works normally and does not break anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-with: @JessicaJiang-123
Summary
Support running Megatron Bridge on Python 3.10.
Changes
Validation
Verified installation and builder imports on Python 3.10. Also verified a Qwen2.5 Megatron to HF weight update through
AutoBridge.from_hf_pretrained.