Alpine 1.1 compat by is-this-c · Pull Request #342 · rafalh/dashfaction

is-this-c · 2025-09-23T13:42:02Z

Changes derived from Alpine Faction's source code
- Improves compatibility with Alpine Faction network protocol
- - Flags::allow_fb_mesh
- - Flags::allow_no_ss
- - Flags::no_player_collide
- - Flags::allow_no_mf
- - Flags::click_limit
- - af_damage_notify_packet
- In Alpine Faction levels
- - Handles AlpineLevelProps::legacy_cyclic_timers
- - Allows triggers to activate events in multiplayer
- - Fixes events that broke if their delay parameter was set
- - Supports loading Alpine Faction's $Lightmap Clamp Floor, and $Lightmap Clamp Ceiling, $Crater Texture PPM, and $Mesh Replacementfrom {map_name}_info.tbl
- - Supports dynamic lights
- - Makes particle emitters placed in levels respect their active distance parameter
Prevents spawning in maps if there are unsupported event classes
New hit_sounds, weapon_screen_shake, full_bright_entities, and remote_server_flags commands

I did not bother cleaning up af_options.cpp so it is just a copy paste.

Resolves #182
Resolves #301

…loop.wav

…/fp_shotgun_reload.wav

….vbm

Consolidate Alpine Faction changes and features in changelog.

rafalh

This PR is getting out of hands. It's really hard to review 1000+ changes (125 commits) multiple times. It takes me a lot of time and I'm still not sure if I didn't skip something. Can you split it into smaller PRs instead of making one big PR with everything? You add new stuff with every revision and fix unrelated stuff like adding const everywhere. If you must add it, okay, but not make huge PRs like this which changes 10 things at the same time. And all those commits have bad titles like "Update". Should I squash them and be left with one big commit in the git history? Every unrelated feature should have it's own commit/PR. Big PR for adding all Alpine stuff is a bad idea.
Small PR would also make it easier for me to find time to review it...

rafalh · 2025-10-26T21:06:03Z

game_patch/graphics/d3d11/gr_d3d11_mesh.cpp

+        const bool ir_scanner = (params.flags & MRF_SCANNER_1) != 0;
+        if (!ir_scanner) {
+            rf::Vector3 ambient_light{0.f, 0.f, 0.f};
+            light_get_ambient(&ambient_light.x, &ambient_light.y, &ambient_light.z);


why it was moved? I can see in RF code that those builtin lights are used for characters too

That is in render_v3d_vif which is for e.g. item pickups. Characters are lighted in render_character_vif.

rafalh · 2025-10-26T21:08:49Z

game_patch/graphics/d3d11/gr_d3d11_mesh.cpp

+        const bool ir_scanner = (params.flags & MRF_SCANNER_1) != 0;
+        if (!ir_scanner) {
+            const bool allow_full_bright = !(get_remote_server_info()
+                && !get_remote_server_info().value().allow_full_bright_entities);


there should be no negation or it should be "deny", not "allow", because currently it makes no sense

const bool allow_full_bright = !(get_remote_server_info() && !get_remote_server_info().value().allow_full_bright_entities);

seems clearer in expressions e.g. if (config.full_bright && allow_full_bright) instead of if (config.full_bright && !no_full_bright)

const bool no_full_bright = get_remote_server_info() && !get_remote_server_info().value().allow_full_bright_entities;

rafalh · 2025-10-26T21:18:34Z

game_patch/misc/af_options.cpp

+AlpineLevelInfoConfig g_af_level_info_config;
+
+// trim leading and trailing whitespace
+std::string trim(const std::string& str, bool remove_quotes = false)


why this file recreates entire parsing module for no reason introducing bugs like not handling escape character in strings? You just copied it from Alpine right? Looks like AI slop :(

I didn't have the energy to go through it since it was an isolated file.

rafalh · 2025-10-26T21:19:39Z

game_patch/misc/level.h

-struct DashLevelProps
-{
-    // backward compatible defaults
+struct AlpineLevelProps {


of course Goober had to copy my way of handling that, but of course he didn't try to handle my chunk, right? I wonder why he didn't make new cyclic timers depend on rfl version

Alpine Faction handles both chunks. legacy_cyclic_timers does depend upon RFL version. See event_type_forwards_messages_patch.

rafalh · 2025-10-26T21:22:36Z

game_patch/misc/af_options.h

+};
+
+struct AlpineLevelInfoConfig {
+    std::unordered_map<std::string, std::unordered_map<AlpineLevelInfoId, LevelInfoValue>> level_options{};


what is this, some kind of cache that you never clean? another AI slop?

Goober agreed it should be for the loaded level only. I've changed it.

rafalh · 2025-10-26T21:52:02Z

game_patch/object/object.cpp

-    [](rf::Object* objp, const char* name, rf::VMeshType type) {
-        rf::VMesh* mesh = obj_create_mesh_hook.call_target(objp, name, type);
+    [] (rf::Object* const objp, const char* name, const rf::VMeshType type) {
+        const std::input_iterator auto level = g_af_level_info_config


level? that's a stupid name. Better mesh_replacements or replacements, because i'ts clearly not a level...

Yeah I missed this somehow.

rafalh · 2025-10-26T21:54:28Z

game_patch/object/particle.cpp

+    int,
+    rf::Particle**,
+    rf::ParticleEmitter*
+)> particle_create_level_emitter_hook{


this name is confusing, it's pretty much a patch for ParticleEmitter::spawn method, but the name suggests it's some kind of constructor for particle emitter itself.

It is called particle_create? What about particle_spawn_level_emitter_hook?

rafalh · 2025-10-26T22:01:33Z

game_patch/rf/particle_emitter.h

    float current_state_time;
    bool active;
-    int field_144;
+    int active_distance;;


Double colon. Also is there a way to set this field in editor?

rafalh · 2025-10-26T22:03:30Z

game_patch/object/obj_light.cpp

+            && !get_remote_server_info().value().allow_full_bright_entities);
+        if (g_game_config.full_bright_entities && allow_full_bright) {
+            // For Direct3d 11, we set in `gr_d3d11_mesh.cpp`.
+            rf::Vector3& ambient_light = addr_as_ref<rf::Vector3>(0x01C3D548);


it's ambient_color, not to be confused with 005A38D4. I didn't check in PS2 code, but that's how it's named in my PC data

From IDA:

ambient_color.x = g_ambient_light.x * 255.0; ambient_color.y = g_ambient_light.y * 255.0; ambient_color.z = g_ambient_light.z * 255.0;

Is it not the same?

rafalh · 2025-10-26T22:08:44Z

game_patch/object/event.cpp

+            // RF does not allow triggers to activate events in multiplayer.
+            // In AF levels, we allow it, unless it is an event that would be 
+            // problematic in multiplayer. 
+            const rf::EventType event_type = static_cast<rf::EventType>(event->event_type);


(opinion) great idea, enable all events without any synchronization of the game state between server and client, especially late client. It probably introduces some quirks and even bugs, but who cares

is-this-c · 2025-10-27T10:39:49Z

This PR is getting out of hands. It's really hard to review 1000+ changes (125 commits) multiple times. It takes me a lot of time and I'm still not sure if I didn't skip something. Can you split it into smaller PRs instead of making one big PR with everything?

Good point. But seems too late...

is-this-c added 30 commits September 24, 2025 00:59

Alpine compat

b082b69

Update server.cpp

13782a3

Update CMakeLists.txt

7d7b2d5

Update CMakeLists.txt

75958f1

Update network.cpp

dad1b0d

Update network.cpp

74a5272

Update gr.cpp

97e144c

Update gr.cpp

08d827b

Update save_restore.cpp

77896f3

Update network.cpp

8b64890

Update weapon.cpp

3e1095b

Update player.cpp

f301672

Update camera.cpp

66e3f0f

Update GameConfig.h

fe19cb1

Update GameConfig.cpp

f8aedec

Update camera.cpp

dd43b7b

Update CHANGELOG.md

8b7523d

Update README.md

460579c

Update README.md

470b4fd

Update camera.cpp

4440cde

Update network.cpp

34eab5e

Add files via upload

307dd7e

Update CMakeLists.txt

3a036bb

Update sound.h

e735be7

Update CHANGELOG.md

710cea3

Rename resources/audio/Laser loop.wav to resources/audio/dummy/Laser …

d3e1926

…loop.wav

Rename resources/audio/fp_shotgun_reload.wav to resources/audio/dummy…

0807f0c

…/fp_shotgun_reload.wav

Rename resources/images/bigboom.vbm to resources/images/dummy/bigboom…

2cb3215

….vbm

Update CMakeLists.txt

6b8c72a

Update CMakeLists.txt

51da624

Update

2b123a0

is-this-c marked this pull request as draft October 16, 2025 12:55

is-this-c added 10 commits October 18, 2025 01:35

Update

a1dbd0b

Update

478697f

Update

ed5d48c

Update

43cc27c

Update CHANGELOG for version 1.9.2

e98b348

Consolidate Alpine Faction changes and features in changelog.

Update

36aacbb

Update

c27159d

Update

73bbe8b

Update

980d6f2

Update

aa2c471

is-this-c requested a review from rafalh October 17, 2025 14:10

is-this-c added 2 commits October 18, 2025 03:17

Update

5e1f1f6

Update

2562fe5

is-this-c marked this pull request as ready for review October 17, 2025 14:41

Update

55764f3

rafalh requested changes Oct 26, 2025

View reviewed changes

is-this-c added 3 commits October 27, 2025 18:26

Rename variables and add enum ServerSoftware

e6388db

Update comment

b1a9c9e

SImplify AlpineLevelInfoConfig

6a49e64

is-this-c added 7 commits October 27, 2025 23:41

Fix build error

eb7ff99

Fix build error

0fed1c8

Fix build error

f8fec28

Fix build error

7428635

Fix build error

61a39ff

use rf::gr::Color::from_hex

ffc489a

Fix build error

c614aa5

is-this-c changed the title ~~Alpine compat~~ Alpine 1.1 compat Dec 18, 2025

Comments

Conversation

is-this-c commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafalh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

is-this-c Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

is-this-c Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

is-this-c Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

is-this-c commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

is-this-c commented Sep 23, 2025 •

edited

Loading

is-this-c Oct 27, 2025 •

edited

Loading

is-this-c Oct 27, 2025 •

edited

Loading

is-this-c Oct 27, 2025 •

edited

Loading