Skip to content

5848 update python and go t5 m5 oasdi age validators to use age first dob calculation#5877

Open
mattcoleanderson wants to merge 7 commits into
developfrom
5848-update-python-and-go-t5-m5-oasdi-age-validators-to-use-age-first-dob-calculation
Open

5848 update python and go t5 m5 oasdi age validators to use age first dob calculation#5877
mattcoleanderson wants to merge 7 commits into
developfrom
5848-update-python-and-go-t5-m5-oasdi-age-validators-to-use-age-first-dob-calculation

Conversation

@mattcoleanderson
Copy link
Copy Markdown

Summary of Changes

Provide a brief summary of changes
Pull request closes #5848

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up --build
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (fc78730) to head (bfdf83a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5877      +/-   ##
===========================================
+ Coverage    94.17%   94.18%   +0.01%     
===========================================
  Files          545      545              
  Lines        25519    25565      +46     
  Branches       620      620              
===========================================
+ Hits         24033    24079      +46     
  Misses        1373     1373              
  Partials       113      113              
Flag Coverage Δ
dev-backend 94.48% <100.00%> (+0.01%) ⬆️
dev-frontend 91.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s-backend/tdpservice/parsers/schema_defs/ssp/m5.py 100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t5.py 100.00% <ø> (ø)
...d/tdpservice/parsers/schema_defs/tribal_tanf/t5.py 100.00% <ø> (ø)
...backend/tdpservice/parsers/validators/category3.py 98.93% <100.00%> (+0.13%) ⬆️
...pservice/parsers/validators/test/test_category3.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf28a63...bfdf83a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Python and Go T5/M5 OASDI age validators to use AGE_FIRST DOB calculation

1 participant