Skip to content

elif statement added#1

Open
raghavagarwal701 wants to merge 1 commit intomainfrom
feature
Open

elif statement added#1
raghavagarwal701 wants to merge 1 commit intomainfrom
feature

Conversation

@raghavagarwal701
Copy link
Copy Markdown
Owner

No description provided.

Comment thread functions.py
if len(matching_elements) == 1 and matching_elements[0]['matching_words'] == len(action_object):
return True, matching_elements[0]['center'], matching_elements[0]['bbox']
elif len(matching_elements) > 1 and matching_elements[0]['matchig_words'] == len(action_object) and matching_elements[1]['matching_words'] != matching_elements[0]['matching_words']:
return True, matching_elements[0]['bbox']
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in added elif check on line 75. Change matchig_words to matching_words to avoid a KeyError. Consider reviewing conditions for accuracy.

@raghavagarwal701
Copy link
Copy Markdown
Owner Author

PR adds an elif statement improving the matching logic. Addressed a typo matchig_words, which could cause runtime errors. Suggested enhancing the parameterization for confidence thresholds. Overall, changes are positive with minor fixes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant