Issue #2: Problems in initialise statement (Solved)#50
Open
pprabh2007 wants to merge 2 commits intorahulkumaran:masterfrom
Open
Issue #2: Problems in initialise statement (Solved)#50pprabh2007 wants to merge 2 commits intorahulkumaran:masterfrom
pprabh2007 wants to merge 2 commits intorahulkumaran:masterfrom
Conversation
Author
|
I have not added 'char' functionality as of now, as you suggested to make changes to only one feature at a time. On a side note, I have it ready with me. Will do it once you approve of this. Hope you like it. Thanks and regards, |
Author
|
There was a confilict with base branch.. I have resolved it.. Please see to it |
Author
|
Any feedback? |
sumanthd17
approved these changes
Dec 17, 2018
Contributor
sumanthd17
left a comment
There was a problem hiding this comment.
This actually solves the problem of multiple spaces between variable, '=' and the value assigned to it. Can be merged. It's good way to write clean code without actually depending on the user to write it based on our need.
Author
|
Any updates or feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Solution to issue #12. I have done my work in a separate function called variable_line, so that all the further additions on this aspect can be easily done, while maintaining the modularity of the code.
Types of Changes
Bug Fix
Summary of Changes
Added a new function called "variable_line", which handles all the bugs related to initialise statements we had discussed about.
Please describe the changes you have made, be as descriptive as you can
Earlier, the indices involving the elements such as variable type, variable identifier and value stored in the variable were hard-coded, due to which the code was quite vulnerable to minor changes in spacing.
Thus, statements such as:
initialise int a=32
initialise b=10.0
would work, whereas statements such as:
initialise int a = 32
initialise b= 10.0
will not work.
The purpose of this Pull Request is solely to solve this issue by making the process very less hard-coded.
If you fixed any bug , Please add screenshots/gifs of the modifications you have done
Please refer to the screenshots I have uploaded for demonstration on the page related to issue #12.
Both the pre-modification and post-modification have been uploaded there for demonstration purposes
If you have added any new feature please add screenshot of the output, how it has been changed after addition of the new feature
.. NA
Checklist
Please checkout the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask .Join our gitter channel and feel free to ask.
I have read the Contribution GuideLines.
Any dependent changes have been merged and published in downstream modules.
Thank You !