Introduce preserve_extname option for directory pin#261
Open
songjiz wants to merge 2 commits intorails:mainfrom
Open
Introduce preserve_extname option for directory pin#261songjiz wants to merge 2 commits intorails:mainfrom
preserve_extname option for directory pin#261songjiz wants to merge 2 commits intorails:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
pin_all_frommethod to properly handle file extensions when pinning directories. It introduces apreserve_extnameoption to retain file extensions when needed, addressing compatibility issues with libraries like Shoelace that require .js extensions in their import statements.Background
Shoelace's autoloader uses import statements that include the .js extension:
The current importmap implementation removes file extensions by default, which can break Shoelace's autoloader functionality.
Usage Example
With these changes, Shoelace can now correctly import components under "@shoelace-style/shoelace/cdn/" while maintaining compatibility with other libraries that don't require extensions.