This repository was archived by the owner on Aug 17, 2017. It is now read-only.
handle UnpermittedParameters as bad request#141
Open
marshallshen wants to merge 1 commit intorails:masterfrom
Open
handle UnpermittedParameters as bad request#141marshallshen wants to merge 1 commit intorails:masterfrom
marshallshen wants to merge 1 commit intorails:masterfrom
Conversation
Contributor
|
Hi, This PR never got any feedback. Would such a change make sense to the maintainers? It could provide more consistency IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we rescue UnpermittedParameters the same way as ParameterMissing? It is cleaner to return as bad request with a meaningful response body rather than raise error in the system.
It shines when you try to build API for services using strong parameters.