ci: add permissions: contents: read to tests#924
Merged
rafaelfranca merged 1 commit intoMay 26, 2026
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: add
permissions: contents: readto.github/workflows/tests.yml.Why: the test workflow doesn't write to the repo. Declaring the minimum scope is what GitHub recommends (docs) and what OpenSSF Scorecard's
Token-Permissionscheck expects.Why now: tj-actions/changed-files (CVE-2025-30066) showed how cheap an explicit
permissions:block is relative to the cost of a leaked write-scoped token.Risk of this change: none observed locally. The token scope is being tightened, not loosened, so the only failure mode would be a step that secretly needed a write scope - which would have to be added back explicitly with a clear justification. YAML still parses (
yaml.safe_load).