Fix compatiblity with latest rails#344
Merged
fatkodima merged 1 commit intorails:mainfrom Feb 18, 2026
Merged
Conversation
Member
|
Urk, having to duplicate Rails code here is really ugly, but alright. |
fatkodima
force-pushed
the
fix-filter-proxies
branch
from
be0c499 to
950462c
Compare
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Feb 18, 2026
web-console 4.2.1 overrides the now-renamed filter_proxies method in ActionDispatch::RemoteIp::GetIp. The fix (rails/web-console#344) is on main but not yet released.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Feb 18, 2026
web-console 4.2.1 overrides the now-renamed filter_proxies method in ActionDispatch::RemoteIp::GetIp. The fix (rails/web-console#344) is on main but not yet released.
driveton
pushed a commit
to arcakit/arcakit
that referenced
this pull request
Feb 20, 2026
web-console 4.2.1 overrides the now-renamed filter_proxies method in ActionDispatch::RemoteIp::GetIp. The fix (rails/web-console#344) is on main but not yet released.
|
Could a new release be cut for this? |
Member
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rails/rails#56836.