Skip to content

Dual Boot RailsBump.org with Rails 8.0 and Rails 8.1 and run 2 test suite jobs #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuanVqz merged 2 commits into from
Mar 24, 2026
Merged

Dual Boot RailsBump.org with Rails 8.0 and Rails 8.1 and run 2 test suite jobs #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7819101
Set up dual booting for Rails 8.0 and Rails 8.1
etagwerker Mar 21, 2026
79d3c3b
Add dual-boot CI matrix for Rails 8.0 and 8.1
etagwerker Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ env:
jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
gemfile: [Gemfile, Gemfile.next]
services:
postgres:
image: postgres:latest
Expand Down Expand Up @@ -61,6 +65,8 @@ jobs:
with:
ruby-version: .ruby-version
bundler-cache: true
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}

- name: Wait for PostgreSQL
run: |
Expand All @@ -77,6 +83,8 @@ jobs:
done

- name: Set up the database
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
run: |
cp config/database.yml.sample config/database.yml
bin/rails db:create
Expand All @@ -85,5 +93,6 @@ jobs:

- name: Run tests
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: COVERAGE=true bundle exec rspec spec
14 changes: 12 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
def next?
File.basename(__FILE__) == "Gemfile.next"
end
source "https://rubygems.org"

ruby file: ".ruby-version"

gem "next_rails"

# gem "activerecord-enhancedsqlite3-adapter", "~> 0.5"
gem "amazing_print", "~> 1.5"
gem "aws-sdk-s3", "~> 1.8", require: false
Expand All @@ -27,8 +32,13 @@ gem "propshaft", "~> 0.8"
gem "pry-rails", "~> 0.3"
gem "puma", "~> 6.4"
gem "rails_bootstrap_navbar", "~> 3.0"
gem "rails", "~> 8.0.0"
gem "rails-i18n", "~> 8.0.0"
if next?
gem "rails", "~> 8.1.0"
gem "rails-i18n", "~> 8.x"
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint "~> 8.x" for rails-i18n is non-standard/ambiguous and can lead to surprising resolution behavior. Prefer an explicit semver range (e.g., "~> 8.0" for any 8.x, or ">= 8.0", "< 9") to clearly communicate intent and keep Bundler resolution predictable.

Suggested change
gem "rails-i18n", "~> 8.x"
gem "rails-i18n", "~> 8.0"

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@JuanVqz JuanVqz Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seeing adding X in the version, is this a typo?

Suggested change
gem "rails-i18n", "~> 8.x"
gem "rails-i18n", "~> 8.x"

Copy link
Copy Markdown
Member Author

@etagwerker etagwerker Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanVqz When I reviewed these changes I was a little surprised by that too!

Apparently it is a thing to use x as a wildcard:

Screenshot 2026-03-24 at 10 11 31 AM

Copy link
Copy Markdown
Member

@JuanVqz JuanVqz Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

else
gem "rails", "~> 8.0.0"
gem "rails-i18n", "~> 8.0.0"
end
gem "redis-namespace", "~> 1.11"
gem "redis", "~> 5.0"
gem "sentry-rails", "~> 5.5"
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ GEM
timeout
net-smtp (0.5.1)
net-protocol
next_rails (1.4.7)
rainbow (>= 3)
nio4r (2.7.4)
nokogiri (1.18.10-arm64-darwin)
racc (~> 1.4)
Expand Down Expand Up @@ -358,6 +360,7 @@ GEM
thor (~> 1.0, >= 1.2.2)
tsort (>= 0.2)
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.3.0)
rchardet (1.8.0)
rdoc (6.15.0)
Expand Down Expand Up @@ -471,6 +474,7 @@ GEM
PLATFORMS
arm64-darwin-23
arm64-darwin-24
arm64-darwin-25
x86_64-linux

DEPENDENCIES
Expand Down Expand Up @@ -499,6 +503,7 @@ DEPENDENCIES
importmap-rails (~> 2.0)
kredis (~> 1.2)
net-pop!
next_rails
octokit (~> 9.1)
octopoller (~> 0.3)
pg
Expand Down
1 change: 1 addition & 0 deletions Gemfile.next
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Gemfile
Loading
Loading