Fixed proc call when form with new record was initialized#7
Open
kirs wants to merge 1 commit intorailsgsoc:masterfrom
Open
Fixed proc call when form with new record was initialized#7kirs wants to merge 1 commit intorailsgsoc:masterfrom
kirs wants to merge 1 commit intorailsgsoc:masterfrom
Conversation
As I guess from `FormDefinition#initialize`, `proc` is never set. In my case, it was always `nil` and for new records, the code evaluated `form.instance_eval(&proc)` where `proc` was nil. That lead to `ArgumentError: wrong number of arguments (0 for 1..3)`.
kirs
force-pushed
the
fixed-proc-call
branch
from
9ab87af to
1f62d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I guess from
FormDefinition#initialize,procis never set.In my case, it was always
niland for new records, the code evaluatedform.instance_eval(&proc)whereprocwas nil. That lead toArgumentError: wrong number of arguments (0 for 1..3).