fix: guard wallet id storage access

.changeset/tidy-wallet-storage.md

@@ -0,0 +1,5 @@
+---
+'@rainbow-me/rainbowkit': patch
+---
+
+Handle unavailable localStorage when reading and writing recent wallet ids.

packages/rainbowkit/src/wallets/latestWalletId.test.ts

@@ -0,0 +1,31 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import {
+  addLatestWalletId,
+  clearLatestWalletId,
+  getLatestWalletId,
+} from './latestWalletId';
+
+function mockUnavailableLocalStorage() {
+  vi.spyOn(window, 'localStorage', 'get').mockImplementation(() => {
+    throw new Error('localStorage unavailable');
+  });
+}
+
+describe('latestWalletId', () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it('returns an empty wallet id when localStorage is unavailable', () => {
+    mockUnavailableLocalStorage();
+
+    expect(getLatestWalletId()).toBe('');
+  });
+
+  it('ignores latest wallet updates when localStorage is unavailable', () => {
+    mockUnavailableLocalStorage();
+
+    expect(() => addLatestWalletId('rainbow')).not.toThrow();
+    expect(() => clearLatestWalletId()).not.toThrow();
+  });
+});

packages/rainbowkit/src/wallets/latestWalletId.ts

@@ -1,19 +1,19 @@
+import {
+  getStorageItem,
+  removeStorageItem,
+  setStorageItem,
+} from './safeLocalStorage';
+
 const storageKey = 'rk-latest-id';
 
 export function getLatestWalletId(): string {
-  return typeof window !== 'undefined'
-    ? window.localStorage.getItem(storageKey) || ''
-    : '';
+  return getStorageItem(storageKey) || '';
 }
 
 export function addLatestWalletId(walletId: string): void {
-  if (typeof window !== 'undefined') {
-    window.localStorage.setItem(storageKey, walletId);
-  }
+  setStorageItem(storageKey, walletId);
 }
 
 export function clearLatestWalletId(): void {
-  if (typeof window !== 'undefined') {
-    window.localStorage.removeItem(storageKey);
-  }
+  removeStorageItem(storageKey);
 }

packages/rainbowkit/src/wallets/recentWalletIds.test.ts

@@ -0,0 +1,26 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import { addRecentWalletId, getRecentWalletIds } from './recentWalletIds';
+
+function mockUnavailableLocalStorage() {
+  vi.spyOn(window, 'localStorage', 'get').mockImplementation(() => {
+    throw new Error('localStorage unavailable');
+  });
+}
+
+describe('recentWalletIds', () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it('returns no recent wallet ids when localStorage is unavailable', () => {
+    mockUnavailableLocalStorage();
+
+    expect(getRecentWalletIds()).toEqual([]);
+  });
+
+  it('ignores recent wallet updates when localStorage is unavailable', () => {
+    mockUnavailableLocalStorage();
+
+    expect(() => addRecentWalletId('rainbow')).not.toThrow();
+  });
+});

packages/rainbowkit/src/wallets/recentWalletIds.ts

@@ -1,3 +1,5 @@
+import { getStorageItem, setStorageItem } from './safeLocalStorage';
+
 const storageKey = 'rk-recent';
 
 function safeParseJsonArray<T>(string: string | null): T[] {
@@ -10,9 +12,7 @@ function safeParseJsonArray<T>(string: string | null): T[] {
 }
 
 export function getRecentWalletIds(): string[] {
-  return typeof window !== 'undefined'
-    ? safeParseJsonArray(window.localStorage.getItem(storageKey))
-    : [];
+  return safeParseJsonArray(getStorageItem(storageKey));
 }
 
 function dedupe<T>(array: T[]): T[] {
@@ -22,7 +22,5 @@ function dedupe<T>(array: T[]): T[] {
 export function addRecentWalletId(walletId: string): void {
   const newValue = dedupe([walletId, ...getRecentWalletIds()]);
 
-  if (typeof window !== 'undefined') {
-    window.localStorage.setItem(storageKey, JSON.stringify(newValue));
-  }
+  setStorageItem(storageKey, JSON.stringify(newValue));
 }

packages/rainbowkit/src/wallets/safeLocalStorage.ts

@@ -0,0 +1,29 @@
+function getSafeLocalStorage(): Storage | undefined {
+  if (typeof window === 'undefined') return;
+
+  try {
+    return window.localStorage;
+  } catch {
+    return;
+  }
+}
+
+export function getStorageItem(key: string): string | null {
+  try {
+    return getSafeLocalStorage()?.getItem(key) ?? null;
+  } catch {
+    return null;
+  }
+}
+
+export function setStorageItem(key: string, value: string): void {
+  try {
+    getSafeLocalStorage()?.setItem(key, value);
+  } catch {}
+}
+
+export function removeStorageItem(key: string): void {
+  try {
+    getSafeLocalStorage()?.removeItem(key);
+  } catch {}
+}