Skip to content

Fixed a crash that may result if layoutManager and textStorage happen… #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajdeep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed a crash that may result if layoutManager and textStorage happen… #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Proton/Sources/Swift/Core/RichTextView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,11 @@ class RichTextView: AutogrowingTextView {
}

override func caretRect(for position: UITextPosition) -> CGRect {
guard isEditable else {
// layoutManager.numberOfGlyphs check is required to prevent cases where selectedRange is accessed
// while TextProcessor is processing and contents are changed to prevent a crash that may result when
// this is not same as textStorage.length
guard isEditable,
layoutManager.numberOfGlyphs == textStorage.length else {
return super.caretRect(for: position)
}

Expand Down