fix(zwave_js): make UC v1 post-write verify failures non-fatal (#1251)

[raman325]

Proposed change

Soften the User Code CC v1 post-write verification poll in the issue-#1251 fallback layer: log a warning and continue on Z-Wave wire errors instead of raising `LockDisconnected`.

The poll exists to force-update the value cache after a SET/CLEAR on V1 locks (which don't reliably push the new value back themselves). On Schlage UC v1 locks with flaky interviews -- the canonical #1251 population -- the verify GET hits the same timeout the interview did, so every credential write went:

1. SET ack'd at the wire ✓
2. Verify GET timed out → `LockDisconnected`
3. Caller treated the whole operation as failed
4. Sync manager retried, hit the same timeout, eventually suspended the slot ✗

That's the "code slots won't stay enabled" symptom TheMegamind reported on #1251 against 4.0.3.

The optimistic `_push_credential_update` runs immediately after the verify, so the coordinator already has the post-write state regardless of whether the GET succeeded. The hourly hard-refresh backstop reconciles any genuine cache drift later. Trading "we couldn't refresh the cache right now" for "the slot survives" matches the safer outcome for a flaky lock.

Non-Z-Wave exceptions (programming bugs) still propagate -- the softening only covers `BaseZwaveJSServerError`.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes [ISSUE] 4.0.2 Code rejected Credential slot for pin_code must be between 1 and 0 #1251
• This PR is related to issue: follow-up to fix(zwave_js): fall back to User Code CC utilities when the unified access-control API is unusable (#1251) #1252

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.

Tests:

• `test_uc_v1_set_verify_failure_logs_warning_and_continues` -- the new behavior on set
• `test_uc_v1_clear_verify_failure_logs_warning_and_continues` -- mirrors the set softening for clear
• `test_uc_v1_verify_non_zwave_error_propagates` -- programming bugs still surface
• (Replaces the prior `test_uc_v1_verify_poll_failure_raises_lock_disconnected`, which encoded the old contract.)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR adjusts the Z-Wave JS User Code CC v1 fallback behavior so that post-write verification GET failures (transport/server errors) no longer fail an otherwise-acknowledged PIN set/clear operation, preventing retry loops and slot suspension on flaky UC v1 locks (issue #1251).

Changes:

• Make UC v1 post-write verification poll failures non-fatal by logging a warning and continuing on BaseZwaveJSServerError.
• Update/replace UC fallback tests to assert the new “warn and continue” behavior for set/clear and to ensure non-Z-Wave exceptions still propagate.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
custom_components/lock_code_manager/providers/_zwave_js_uc.py	Softens UC v1 post-write verification failures from raising LockDisconnected to emitting a warning and proceeding.
tests/providers/zwave_js/test_uc_fallback.py	Replaces the prior “verify failure raises” test with new coverage for warning-and-continue on set/clear, plus propagation for non-Z-Wave errors.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.11%. Comparing base (facab24) to head (32de8e3).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          54       54           
  Lines        6411     6411           
  Branches      461      461           
=======================================
  Hits         6226     6226           
  Misses        185      185           

Flag	Coverage Δ
python	97.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...onents/lock_code_manager/providers/_zwave_js_uc.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.