Skip to content

Fix issue-labeler patterns to use portable cross-line matching #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raman325 merged 1 commit into from
Jan 15, 2026
Merged

Fix issue-labeler patterns to use portable cross-line matching #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/issue-labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
# Configuration for github/issue-labeler - body-based labels
# See: https://github.com/github/issue-labeler
# Uses regex patterns to match PR/issue body content
# All checkbox patterns require ## Type of change header first to avoid matching examples
# Checkbox patterns use (.|[\r\n])*? for cross-line matching ([\s\S] may not work in all engines)
---
bug:
- '## Type of change[\s\S]*?- \[[xX]\]\s*[Bb]ugfix'
- '## Type of change(.|[\r\n])*?- \[[xX]\]\s*[Bb]ugfix'

enhancement:
- '## Type of change[\s\S]*?- \[[xX]\]\s*[Nn]ew [Ff]eature'
- '## Type of change(.|[\r\n])*?- \[[xX]\]\s*[Nn]ew [Ff]eature'

breaking-change:
# Checkbox in Type of change section
- '## Type of change[\s\S]*?- \[[xX]\]\s*[Bb]reaking [Cc]hange'
- '## Type of change(.|[\r\n])*?- \[[xX]\]\s*[Bb]reaking [Cc]hange'
# Breaking change section with content after HTML comment
- '^[\s\S]*?# Breaking change[\s\S]*?-->\s*\n+[A-Z][a-z]+[\s\S]*?## Proposed change'
- '# Breaking change(.|[\r\n])*?-->\s*\n+[A-Z][a-z]+(.|[\r\n])*?## Proposed change'

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern # Breaking change matches any line containing '# Breaking change', not just a section header. This could produce false positives if that text appears elsewhere in the PR body. The pattern should be anchored or more specific to match the actual section structure from the PR template.

Copilot uses AI. Check for mistakes.
# Breaking change section with HTML comment removed
- '^[\s\S]*?# Breaking change\s*\n+[A-Z][a-z]+[\s\S]*?## Proposed change'
- '# Breaking change\s*\n+[A-Z][a-z]+(.|[\r\n])*?## Proposed change'

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern requires text starting with a capital letter followed by lowercase letters ([A-Z][a-z]+), but breaking change descriptions could start with various patterns (e.g., numbers, multiple capital letters, special characters). This is too restrictive and may miss valid breaking changes.

Copilot uses AI. Check for mistakes.
Comment on lines +16 to +18

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both breaking-change patterns require content between the breaking change section and the 'Proposed change' section to start with [A-Z][a-z]+. According to the PR template, users are expected to remove the breaking change section if not applicable. These patterns may not correctly identify breaking changes if users provide different content formats or simply check the checkbox without filling in the breaking change section.

Copilot uses AI. Check for mistakes.

code-quality:
- '## Type of change[\s\S]*?- \[[xX]\]\s*[Cc]ode [Qq]uality'
- '## Type of change(.|[\r\n])*?- \[[xX]\]\s*[Cc]ode [Qq]uality'
Loading