Document bounty preflight quality gate#450
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCONTRIBUTING.md is updated with a new "Preflight Checks" section that documents a local validation workflow for bounty PRs. Contributors are instructed to draft their PR body and run ChangesBounty submission preflight documentation
Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
weilixiong
left a comment
There was a problem hiding this comment.
LGTM — preflight quality gate docs in CONTRIBUTING.md. Docs-only, clear instructions. Zero risk.
adliebe
left a comment
There was a problem hiding this comment.
Requested changes because PR #450 duplicates already-open PR #429.
Evidence checked:
- PR #450 and PR #429 have the same title:
Document bounty preflight quality gate. - Both touch only
CONTRIBUTING.md. - Both have the same diff stat: 15 additions, 0 deletions.
- The added hunk is identical:
## Preflight Checks, the samepython scripts/submission_quality_gate.py --text-file pr-body.md --repo ramimbo/mergeworkcommand, and the same paragraph about bounty reference, summary, validation evidence, open award capacity, active attempts, similar open PRs, and recent maintainer activity. - PR #429 is still open and already has prior human review history.
Validation:
- Fetched
pull/429/head:pr-429andpull/450/head:pr-450. git diff --stat 12c3dbd462d6647d50bfc8115b852e7cb338bb5b..pr-450->CONTRIBUTING.md | 15 +++++++++++++++git diff --stat 764e9ed91b0b28b6eb8a7501ecf6bc85b497c4c7..pr-429->CONTRIBUTING.md | 15 +++++++++++++++- The no-color diffs for both PRs show the same inserted hunk.
- On PR #450 head
a5f1b7b6058c653a5fc757e5037967b5810cbaaa:python scripts/docs_smoke.py-> docs smoke ok ruff check CONTRIBUTING.md scripts/submission_quality_gate.py tests/test_submission_quality_gate.py-> All checks passedgit diff --check 12c3dbd462d6647d50bfc8115b852e7cb338bb5b..pr-450-> clean- GitHub combined status for PR #450 head is
successwith CodeRabbit success.
Recommendation: close PR #450 as duplicate of PR #429, or reopen with a non-overlapping documentation improvement after #429 is resolved.
Summary
CONTRIBUTING.mdfor bounty PR authors.scripts/submission_quality_gate.py --text-file ... --repo ...advisory workflow and what it checks.Refs #426
Evidence
scripts/submission_quality_gate.py, which checks bounty references, summary/evidence signals, payability, active attempts, similar open PRs, and maintainer activity when available.docs/agent-guide.mdalready documents this gate for agents; this PR adds the same contributor-facing preflight guidance to the main contributor entrypoint.origin/mainis one file:CONTRIBUTING.md, 15 insertions.Test Evidence
python scripts/check_agents.py-> AGENTS.md okpython scripts/docs_smoke.py-> docs smoke okpython -m pytest-> 413 passedpython -m ruff check .-> passedpython -m ruff format --check .-> 79 files already formattedpython -m mypy app-> successpython scripts/check_deploy_ready.pywith CI env values -> passeddocker build -t mergework:ci .-> passedgit diff --check origin/main...HEAD-> passedMRWK
Related bounty or issue (
Bounty #NorRefs #Nfor multi-award bounties): Refs #426Summary by CodeRabbit