Skip to content

Docs: add recent governance review payment rows#565

Closed
xingxi0614-cpu wants to merge 1 commit into
ramimbo:mainfrom
xingxi0614-cpu:codex/b426-recent-governance-paid-index
Closed

Docs: add recent governance review payment rows#565
xingxi0614-cpu wants to merge 1 commit into
ramimbo:mainfrom
xingxi0614-cpu:codex/b426-recent-governance-paid-index

Conversation

@xingxi0614-cpu
Copy link
Copy Markdown

@xingxi0614-cpu xingxi0614-cpu commented May 28, 2026

Summary

Evidence

Validation

  • uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • uv run --extra dev python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_governance_review_payments -q -> 1 passed
  • uv run --extra dev python -m pytest tests/test_docs_public_urls.py -q -> 24 passed
  • uv run --extra dev ruff check docs/paid-bounties.md tests/test_docs_public_urls.py -> passed
  • uv run --extra dev ruff format --check tests/test_docs_public_urls.py -> already formatted
  • git diff --check -> clean

Safety

  • Public documentation/proof-index update only.
  • No private keys, wallet secrets, cookies, OAuth state, admin tokens, deployment credentials, private vulnerability details, price claims, exchange claims, bridge claims, off-ramp claims, or fabricated payout claims.

Summary by CodeRabbit

  • Documentation

    • Added recent governance MVP review payment entries to the paid bounties documentation, including complete proof links and token awards for completed community review work.
  • Tests

    • Added automated verification test to validate the bounty documentation includes all governance review entries with correct formatting, proper proof links, and accurate payment records.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 96aa85ca-9b03-44c2-b368-f667dcd8e3a0

📥 Commits

Reviewing files that changed from the base of the PR and between d8532d4 and 1e6bd8a.

📒 Files selected for processing (2)
  • docs/paid-bounties.md
  • tests/test_docs_public_urls.py

📝 Walkthrough

Walkthrough

Adds nine new bounty records to docs/paid-bounties.md for 2026-05-27, documenting paid MRWK awards for governance MVP PR review work tied to issues #512 and #459, with proof URLs. Adds a test in tests/test_docs_public_urls.py that validates the bounty entries, checking for specific row formats, payment amounts, and PR references.

Changes

Paid Bounties Recording

Layer / File(s) Summary
Bounty entries and validation
docs/paid-bounties.md, tests/test_docs_public_urls.py
Nine new bounty rows dated 2026-05-27 are added, each awarding 80 MRWK for governance MVP PR review work tied to issues #512 and #459, with proof links. The test validates bounty titles, PR references, minimum row counts, and exact formatted entries for each recipient/proof hash combination.

Possibly related PRs

  • ramimbo/mergework#414: Modifies docs/paid-bounties.md by appending new dated paid bounty table rows (May 26).
  • ramimbo/mergework#448: Updates both docs/paid-bounties.md with new bounty rows and extends tests/test_docs_public_urls.py with pytest assertions validating PR-to-proof mappings.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Mergework Public Artifact Hygiene ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Bounty Pr Focus ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the main change: adding recent governance review payment rows to docs.
Description check ✅ Passed Description covers summary, evidence, and validation sections with specific evidence and test results provided.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@eliasx45 eliasx45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these payment rows and a focused regression test. I checked this locally against 1e6bd8a767588446f91315a5afe893b6f5ddabf9.

Finding: the new regression test only pins 4 of the 17 added 2026-05-27 payment rows exactly. The remaining 13 rows are covered only by broad count assertions (>= 7, >= 10, >= 17) plus generic PR text checks. That would let a future edit swap a recipient, accepted-work URL, or proof hash for most of the new rows while this test still passes, which is risky for docs/paid-bounties.md because these rows are the public payment index.

Concrete evidence:

  • docs/paid-bounties.md:9-25 adds 17 new 2026-05-27 rows.
  • tests/test_docs_public_urls.py:53-82 includes 4 exact expected_rows; tests/test_docs_public_urls.py:84-88 uses loose count checks for the rest.
  • Local static check: 17 new proof hashes, 4 asserted exactly by the test, 13 not exact-pinned (5880de2e, 5dccd890, 05f91540, 20b5a85c, 43a7fd6a, dddffc31, 3ffd5807, 77ba30c0, 1d602580, 089cabf0, dc1740d3, 7ff67760, d0213037).
  • I verified all 17 https://mrwk.ltclab.site/proofs/<hash> pages return HTTP 200 and include their hash in the response body, so the docs rows themselves look reachable; the issue is test coverage completeness.

Suggested fix: add the other 13 rows to expected_rows, or parse all newly documented 2026-05-27 rows into (bounty, accepted_work, recipient, proof) tuples and assert the full expected set. That will make the regression guard match the proof-backed nature of the change.

Commands run:

  • .\.venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_governance_review_payments -q -> passed
  • .\.venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py -q -> 24 passed
  • .\.venv\Scripts\python.exe scripts\docs_smoke.py -> docs smoke ok
  • .\.venv\Scripts\python.exe -m ruff check tests/test_docs_public_urls.py -> all checks passed
  • git diff --check origin/main...HEAD -> passed

Copy link
Copy Markdown

@eliasx45 eliasx45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 1e6bd8a767588446f91315a5afe893b6f5ddabf9 as a non-author.

No blocker found. The PR is narrowly scoped to docs/paid-bounties.md plus a regression in tests/test_docs_public_urls.py, and the new governance-review payment rows match the public proof pages I spot-checked: issue #512/#459, PR #458 submissions, 80 MRWK amount, and listed recipients/proof hashes.

Validation performed:

  • git diff --check origin/main...HEAD clean
  • python -m pytest tests/test_docs_public_urls.py -q -> 24 passed
  • python scripts/docs_smoke.py -> docs smoke ok
  • python -m ruff check docs/paid-bounties.md tests/test_docs_public_urls.py
  • python -m ruff format --check tests/test_docs_public_urls.py
  • Public URL/proof HEAD checks returned 200 for the new GitHub and proof links inspected
  • Full suite: python -m pytest -q -> 415 passed
  • Hosted Quality/readiness/docs/image checks are passing

No private data, credentials, wallet material, price/off-ramp claims, exchange/liquidity claims, or fabricated payout claims were used.

@ramimbo
Copy link
Copy Markdown
Owner

ramimbo commented May 28, 2026

Closing as superseded by #573. The project now treats proof-backed activity, bounty detail, ledger, and proof records as the payment source of truth instead of adding dated rows to docs/paid-bounties.md. Keeping this PR would reintroduce the manual index that #573 removed, so it is not accepted for the #426 docs bounty.

@ramimbo ramimbo added duplicate This issue or pull request already exists mrwk:rejected Submission rejected labels May 28, 2026
@ramimbo ramimbo closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists mrwk:rejected Submission rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants