Docs: add recent governance review payment rows#565
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds nine new bounty records to ChangesPaid Bounties Recording
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
eliasx45
left a comment
There was a problem hiding this comment.
Thanks for adding these payment rows and a focused regression test. I checked this locally against 1e6bd8a767588446f91315a5afe893b6f5ddabf9.
Finding: the new regression test only pins 4 of the 17 added 2026-05-27 payment rows exactly. The remaining 13 rows are covered only by broad count assertions (>= 7, >= 10, >= 17) plus generic PR text checks. That would let a future edit swap a recipient, accepted-work URL, or proof hash for most of the new rows while this test still passes, which is risky for docs/paid-bounties.md because these rows are the public payment index.
Concrete evidence:
docs/paid-bounties.md:9-25adds 17 new 2026-05-27 rows.tests/test_docs_public_urls.py:53-82includes 4 exactexpected_rows;tests/test_docs_public_urls.py:84-88uses loose count checks for the rest.- Local static check: 17 new proof hashes, 4 asserted exactly by the test, 13 not exact-pinned (
5880de2e,5dccd890,05f91540,20b5a85c,43a7fd6a,dddffc31,3ffd5807,77ba30c0,1d602580,089cabf0,dc1740d3,7ff67760,d0213037). - I verified all 17
https://mrwk.ltclab.site/proofs/<hash>pages return HTTP 200 and include their hash in the response body, so the docs rows themselves look reachable; the issue is test coverage completeness.
Suggested fix: add the other 13 rows to expected_rows, or parse all newly documented 2026-05-27 rows into (bounty, accepted_work, recipient, proof) tuples and assert the full expected set. That will make the regression guard match the proof-backed nature of the change.
Commands run:
.\.venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_governance_review_payments -q-> passed.\.venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py -q-> 24 passed.\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke ok.\.venv\Scripts\python.exe -m ruff check tests/test_docs_public_urls.py-> all checks passedgit diff --check origin/main...HEAD-> passed
eliasx45
left a comment
There was a problem hiding this comment.
Reviewed current head 1e6bd8a767588446f91315a5afe893b6f5ddabf9 as a non-author.
No blocker found. The PR is narrowly scoped to docs/paid-bounties.md plus a regression in tests/test_docs_public_urls.py, and the new governance-review payment rows match the public proof pages I spot-checked: issue #512/#459, PR #458 submissions, 80 MRWK amount, and listed recipients/proof hashes.
Validation performed:
git diff --check origin/main...HEADcleanpython -m pytest tests/test_docs_public_urls.py -q-> 24 passedpython scripts/docs_smoke.py-> docs smoke okpython -m ruff check docs/paid-bounties.md tests/test_docs_public_urls.pypython -m ruff format --check tests/test_docs_public_urls.py- Public URL/proof HEAD checks returned 200 for the new GitHub and proof links inspected
- Full suite:
python -m pytest -q-> 415 passed - Hosted Quality/readiness/docs/image checks are passing
No private data, credentials, wallet material, price/off-ramp claims, exchange/liquidity claims, or fabricated payout claims were used.
|
Closing as superseded by #573. The project now treats proof-backed activity, bounty detail, ledger, and proof records as the payment source of truth instead of adding dated rows to |
Summary
docs/paid-bounties.md.Evidence
ramimbo/mergeworkreview work on PR add treasury governance proposals #458.paid-bounties.mdreconciliation PR for these MRWK bounty: detailed governance MVP PR review #459/MRWK bounty: detailed governance MVP PR review, part 2 #512 rows. PR Refs #426: Document payout reconciliation runbook #529 is a payout reconciliation runbook doc, not the proof-row index update.Validation
uv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_governance_review_payments -q-> 1 passeduv run --extra dev python -m pytest tests/test_docs_public_urls.py -q-> 24 passeduv run --extra dev ruff check docs/paid-bounties.md tests/test_docs_public_urls.py-> passeduv run --extra dev ruff format --check tests/test_docs_public_urls.py-> already formattedgit diff --check-> cleanSafety
Summary by CodeRabbit
Documentation
Tests