feat: integrate Rabbitizer via FetchContent #30
+67
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran-j
requested changes
Jan 29, 2026
| if (sym && sym->isFunction) | ||
| { | ||
| return sym->name; | ||
| return sanitizeFunctionName(sym->name); |
Owner
There was a problem hiding this comment.
this will cause an error because the function body is online 78.
Contributor
There was a problem hiding this comment.
Adding "CodeGenerator::" to the beginning should solve the problem.
return CodeGenerator::sanitizeFunctionName(sym->name);and add this to code_generator.h:
std::string sanitizeFunctionName(const std::string& name);| { | ||
| if (inst.opcode == OPCODE_JAL) | ||
| { | ||
| uint32_t target = (inst.address & 0xF0000000) | (inst.target << 2); |
Owner
There was a problem hiding this comment.
We dont need (currentAddr + 4) & 0xF0000000 . Rabbitizer already gives the full VRAM target,
So repllace (inst.address & 0xF0000000) | (inst.target << 2) with inst.target; in alll places
| : m_elfPath(elfPath) | ||
| { | ||
| m_elfParser = std::make_unique<ElfParser>(elfPath); | ||
| m_decoder = std::make_unique<R5900Decoder>(); |
Owner
There was a problem hiding this comment.
Also delete the file and the test if they use it.
Owner
|
Nice work @Lucasnribeiro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing this issue #17