Skip to content

Instantiate menuInterface earlier to avoid race condition#82

Open
iquito wants to merge 1 commit intoranbuch:masterfrom
iquito:patch-1
Open

Instantiate menuInterface earlier to avoid race condition#82
iquito wants to merge 1 commit intoranbuch:masterfrom
iquito:patch-1

Conversation

@iquito
Copy link

@iquito iquito commented Oct 8, 2024

When trying to overwrite a menu element via something like this:

var instance = new Accessibility();
instance.menuInterface.increaseText = function() {
    // My own way to increase text size . . .
}

I had the problem that I got the error "Cannot set properties of undefined", because it seems menuInterface had not been created when I tried to call the code, because it is created in the "build" method of the class Accessibility which is called in an async way. Looking through the code I did not find a reason why menuInterface is not just defined early in the constructor (maybe in the past there was a reason why it was initialized this late, but that reason is not around anymore?).

So I suggest to just create the object early on and not in an async method in order to make overwriting menu items work as suggested in the manual - currently I guess it is a race condition, but I would assume it usually fails, as it fails every time on my project. If I run the same code 2 seconds later it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant