fix: update images to latest tag in manifests#384
fix: update images to latest tag in manifests#384lexfrei wants to merge 2 commits intorancher:masterfrom
Conversation
Signed-off-by: Aleksei Sviridkin <f@lex.la>
|
I don't really want to get in the habit of bumping the version here in the checked-in manifest. If you want to use the manifest from git, use Kustomize to target whatever release you want. If you want a manifest that has an updated version in it, use the release artifacts. |
|
Thanks for the feedback, @brandond! I understand your perspective on not bumping versions in the checked-in manifests. I'd like to share some context from the ArgoCD user community perspective. README Installation Method Issue: The official README recommends installation via ArgoCD Workflow Challenge: For ArgoCD users, git sources work perfectly fine for deployments. However, combining Kustomize overlays with git sources in a single ArgoCD Application is challenging and adds significant complexity. The alternative — consuming artifacts from GitHub releases — is not possible in ArgoCD at all. ArgoCD simply cannot pull manifests from release artifacts. Alternative Suggestion: If you prefer not to bump specific versions in the manifests, would switching to Community Workaround: Given these challenges, I've created a community Helm chart that's fully functional and actively used in production: https://artifacthub.io/packages/helm/system-upgrade/system-upgrade-controller This chart is completely independent of #248 (Helm chart PR open since 2023). If there's interest in official Helm chart support for this project, I'd be happy to contribute this chart to this repository. I initially kept it separate given the uncertainty around #248, but I'm open to transferring it if that would benefit the community. Closing Note: I'm not pushing for this specific PR to be merged (especially since v0.17.0 is now out). I wanted to raise this feedback on behalf of the ArgoCD community experiencing these pain points with the current installation methods. Thanks for maintaining this project! |
Changed both controller and kubectl images to latest tag: - rancher/system-upgrade-controller: v0.16.3 -> latest - rancher/kubectl: v1.30.3 -> latest This ensures YOLO users following the official README get the most recent versions instead of outdated pinned tags. Addresses the issue where git-based manifests were significantly behind current releases (e.g. v0.14.0 vs v0.17.0). Co-Authored-By: Claude <noreply@anthropic.com>
Updated the hardcoded image tag for system-upgrade-controller to v0.16.3.
Notes:
Please move the tag on master after merging to ensure this change is included in the referenced tag.
UPDATE (2025-10-24):
Changed approach based on maintainer feedback. Instead of pinning to a specific version, updated both images to
latesttag:rancher/system-upgrade-controller: v0.16.3 → latestrancher/kubectl: v1.30.3 → latestThis ensures YOLO users following the official README installation method get current versions without requiring manual manifest updates.