Skip to content

fix: bugs, lint errors, dead code, and dev tools exposure#53

Open
t0kubetsu wants to merge 1 commit into
mainfrom
fix/bugs-and-cleanup
Open

fix: bugs, lint errors, dead code, and dev tools exposure#53
t0kubetsu wants to merge 1 commit into
mainfrom
fix/bugs-and-cleanup

Conversation

@t0kubetsu
Copy link
Copy Markdown

Summary

  • Fixes a runtime 404 caused by a double slash in the Proxmox network node list API endpoint (/network//node/list/network/node/list)
  • Resolves a Pinia store ID collision: proxmoxSettingsStore.ts and useProxmoxSettings.js both registered under 'proxmoxSettings'; the TS store is now 'proxmoxSettingsV1'
  • Replaces the stale scaffold unit test (always-failing 'You did it!' assertion) with a real App mount smoke test
  • Removes 30+ unused variable declarations and imports across ProjectEditor.vue, Dashboard.vue, ConfigPanel.vue, Sidebar.vue, App.vue, and several TS composables
  • Adds defineOptions multi-word names to Settings, Dashboard, and Sidebar components to satisfy vue/multi-word-component-names
  • Gates vite-plugin-vue-devtools on mode === 'development' so it is no longer bundled into production builds
  • Renames package.json "name" from the scaffolding placeholder "vue-project" to "range42-deployer-ui"
  • Adds typescript-eslint with TypeScript parser for Vue SFCs so .ts files and <script lang="ts"> blocks are properly linted; updates vitest.config.js to handle the function-form vite config

Closes #44, #45, #46, #47, #48, #49, #52

Test plan

  • npm run lint passes with 0 errors
  • npm run test:unit -- --run passes (1/1)
  • npm run build completes successfully
  • Confirm vite-plugin-vue-devtools is not present in the production dist/

- Fix double slash in /network//node/list API endpoint (closes #44)
- Rename proxmoxSettingsStore Pinia ID to proxmoxSettingsV1 to avoid collision with useProxmoxSettings.js (closes #45)
- Replace stale scaffold test with real App mount smoke test (closes #46)
- Remove 30+ unused variables and imports across ProjectEditor.vue, Dashboard.vue, ConfigPanel.vue, Sidebar.vue, App.vue, and TS composables (closes #47, #48)
- Add defineOptions multi-word names to Settings, Dashboard, Sidebar views (closes #48)
- Gate vite-plugin-vue-devtools on mode === 'development' only (closes #49)
- Rename package.json name from vue-project to range42-deployer-ui (closes #52)
- Add typescript-eslint with TypeScript parser for Vue SFCs; fix vitest.config.js to resolve function-form vite config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: double slash in Proxmox network node list API endpoint

1 participant