fix: bugs, lint errors, dead code, and dev tools exposure#53
Open
t0kubetsu wants to merge 1 commit into
Open
Conversation
- Fix double slash in /network//node/list API endpoint (closes #44) - Rename proxmoxSettingsStore Pinia ID to proxmoxSettingsV1 to avoid collision with useProxmoxSettings.js (closes #45) - Replace stale scaffold test with real App mount smoke test (closes #46) - Remove 30+ unused variables and imports across ProjectEditor.vue, Dashboard.vue, ConfigPanel.vue, Sidebar.vue, App.vue, and TS composables (closes #47, #48) - Add defineOptions multi-word names to Settings, Dashboard, Sidebar views (closes #48) - Gate vite-plugin-vue-devtools on mode === 'development' only (closes #49) - Rename package.json name from vue-project to range42-deployer-ui (closes #52) - Add typescript-eslint with TypeScript parser for Vue SFCs; fix vitest.config.js to resolve function-form vite config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/network//node/list→/network/node/list)proxmoxSettingsStore.tsanduseProxmoxSettings.jsboth registered under'proxmoxSettings'; the TS store is now'proxmoxSettingsV1''You did it!'assertion) with a real App mount smoke testProjectEditor.vue,Dashboard.vue,ConfigPanel.vue,Sidebar.vue,App.vue, and several TS composablesdefineOptionsmulti-word names toSettings,Dashboard, andSidebarcomponents to satisfyvue/multi-word-component-namesvite-plugin-vue-devtoolsonmode === 'development'so it is no longer bundled into production buildspackage.json"name"from the scaffolding placeholder"vue-project"to"range42-deployer-ui"typescript-eslintwith TypeScript parser for Vue SFCs so.tsfiles and<script lang="ts">blocks are properly linted; updatesvitest.config.jsto handle the function-form vite configCloses #44, #45, #46, #47, #48, #49, #52
Test plan
npm run lintpasses with 0 errorsnpm run test:unit -- --runpasses (1/1)npm run buildcompletes successfullyvite-plugin-vue-devtoolsis not present in the productiondist/