added calendar code#2
Open
rani-i3 wants to merge 3 commits into
Open
Conversation
JunichiIto
reviewed
Sep 3, 2023
| require 'date' | ||
| require 'optparse' | ||
|
|
||
| # コマンドラインでparseする |
There was a problem hiding this comment.
WHYを説明するコメントでなければ、削除してください〜。
|
|
||
| # date enumeratorを作る | ||
| date_range = Date.new(year, month, 1)..Date.new(year, month, -1) | ||
| dates_enum = date_range.to_enum |
There was a problem hiding this comment.
to_enumせずにRangeオブジェクトのままでもカレンダープログラムは作れるはずです。
困ったことが出てきたら、RangeクラスのAPIドキュメントを調べてみてください〜。
| puts if date.saturday? | ||
| end | ||
|
|
||
| puts "\n" |
There was a problem hiding this comment.
puts自身が改行してくれるので、改行文字をputsする必要はないです〜。
| dates_enum = date_range.to_enum | ||
|
|
||
| # カレンダーを表示する | ||
| puts "\n#{Date::MONTHNAMES[month]} #{year}".center(20) |
There was a problem hiding this comment.
スクショを見ると中央寄せになってないように見えました。
スクショが古いんでしょうか？
| end | ||
|
|
||
| puts "\n" | ||
|
|
JunichiIto
reviewed
Sep 5, 2023
| date_range = Date.new(year, month, 1)..Date.new(year, month, -1) | ||
|
|
||
| calendar_title = "#{month}月 #{year}" | ||
| puts calendar_title.center(20) |
There was a problem hiding this comment.
スクショを見るとcenterの意味がないように見えますね。
OSのcalコマンドを実行して、それと同じ見た目になるように修正してみてください。
Owner
Author
There was a problem hiding this comment.
ああーそれは古いスクショだと思います。今のコードの状態だと、こういう形になりました：
centerとかrjustを使いたいと思いましたが、結局同じ結果なのでcenterにしました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.