Add EventSourceBuilder for configuring EventSource with credentials#530
Merged
Madoshakalaka merged 3 commits intoranile:masterfrom Mar 23, 2026
Merged
Add EventSourceBuilder for configuring EventSource with credentials#530Madoshakalaka merged 3 commits intoranile:masterfrom
Madoshakalaka merged 3 commits intoranile:masterfrom
Conversation
Madoshakalaka
approved these changes
Mar 23, 2026
Collaborator
Madoshakalaka
left a comment
Madoshakalaka
left a comment
There was a problem hiding this comment.
Looks clean. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
EventSourceBuilderto allow creatingEventSourceinstances with custom options, specifically withCredentials for cross-origin requests #286.Proposed changes:
EventSourceBuilderwhich should be future proof if other options need to be added later.