Skip to content

for newer version of bcftools#241

Open
zyllifeworld wants to merge 4 commits intoraphael-group:masterfrom
zyllifeworld:master
Open

for newer version of bcftools#241
zyllifeworld wants to merge 4 commits intoraphael-group:masterfrom
zyllifeworld:master

Conversation

@zyllifeworld
Copy link
Copy Markdown

No description provided.

@vineetbansal
Copy link
Copy Markdown
Collaborator

vineetbansal commented Jan 7, 2026

@zyllifeworld - thanks. Perhaps you'd consider editing this PR by checking the version of bcftools by running the command f"{self.bcftools} --version" (or whatever variation of this reports the version) and form the command appropriately for both old and new versions of bcftools?

I've been out of touch with hatchet for quite a while so I may be missing something here, but that's the general idea.

Add bcftools version detection and conditional logic to handle AD field name differences across bcftools releases.
@zyllifeworld
Copy link
Copy Markdown
Author

@vineetbansal -Thanks a lot for the tip! I’ve already made the change: the code now checks the bcftools version and adjusts the command format based on whether it’s an older or newer release. Hope this works better for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants