Add geomGetLongestSurroundingRectangle and rename SSR type#308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
geomGetLongestSurroundingRectanglealongside the existinggeomGetSmallestSurroundingRectangle, and renames theSSRinterface toSurroundingRectangle.Changes
geomGetLongestSurroundingRectangle— returns the surrounding rectangle whose longest side is maximized. This may result in generating a more intuitive bounding box around features with a dominant axis (like buildings), and may be useful for placing labels and icons aligned to a building's dominant axis.SSR→SurroundingRectanglefor clarity.getSurroundingRectanglehelper, differing only in their scoring strategy.Setkeyed onMath.round(angle / ANGLE_EPSILON), avoiding testing of redundant rotations.reducewith afor...ofloop for extent accumulation; inlined rotation math to avoid allocating a temporary rotated-polygon array.offAxisLShapedBuildingPoints) and assertions verifying both functions choose the correct envelope orientation.Closes #267
Closes facebook/Rapid#1045