[FEA] Remove kmeans::fit_predict, optionally keep predicted labels from fit#1939
Open
lowener wants to merge 5 commits intorapidsai:mainfrom
Open
[FEA] Remove kmeans::fit_predict, optionally keep predicted labels from fit#1939lowener wants to merge 5 commits intorapidsai:mainfrom
lowener wants to merge 5 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cjnolet
reviewed
Mar 25, 2026
cpp/src/cluster/kmeans_balanced.cuh
Outdated
| typename IndexT, | ||
| typename LabelT, | ||
| typename MappingOpT = raft::identity_op> | ||
| void fit_predict(const raft::resources& handle, |
Member
There was a problem hiding this comment.
Question- can we just remove fit_predict() and use fit() as the only mechanism for passing optional labels? Would be nice to clean this up and remove it altogether.
Contributor
Author
There was a problem hiding this comment.
Yes it would be possible to only have fit().
Note: I created #1944 to add a C API to fit_predict(). If we want to go with only fit() then we should skip it before introducing it.
Signed-off-by: Mickael Ide <mide@nvidia.com>
Signed-off-by: Mickael Ide <mide@nvidia.com>
Signed-off-by: Mickael Ide <mide@nvidia.com>
lowener
force-pushed
the
26.06-kmeans-fit
branch
from
d8cdbe5 to
8e4c7dc
Compare
lowener
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I remove the
kmeans::fit_predict()function, to instead add an optional to keep the labels already computed infit().Some unnecessary template instantiation are removed as well.