Conversation
| cpp_api/cluster.rst | ||
| cpp_api/distance.rst | ||
| cpp_api/neighbors.rst | ||
| cpp_api/neighbors_mg.rst |
There was a problem hiding this comment.
Oh I see- you put these out in the top-level for the C++ itself. Hmm. That's not awful. I think it's easier for users to find it this way. I think this is okay. When you said top-leve, I thought you measnt the top level index of the docs themselves.
I still wonder though- would this be better placed inside of the neighbors index? It seems like it'd make more sense there, rather than having it parallel to the other namespaces.
There was a problem hiding this comment.
Yeah, I was thinking it would be easier to find for users to have it moved up. But we can keep it in neighbors if you prefer.
| python_api/cluster.rst | ||
| python_api/distance.rst | ||
| python_api/neighbors.rst | ||
| python_api/neighbors_multi_gpu.rst |
There was a problem hiding this comment.
I think I'd prefer if this was nested inside "neighbors".
| @@ -1,5 +1,6 @@ | |||
| document.addEventListener("DOMContentLoaded", () => { | |||
| const toc = document.querySelector(".bd-toc-nav"); | |||
| const toc = document.querySelector("#pst-page-toc-nav") || | |||
There was a problem hiding this comment.
Can you briefly describe what this change does?
There was a problem hiding this comment.
This is to fix point 6. Fix overload grouping on right sidebar.
For example instead of showing build a bunch of times, it shows build once. This used to work before without the change, but maybe there was some dependency update that made it stop working.
Ref: #1377
Continued overhaul of cuvs docs:
How to build docs locally