[FEA] Standardize KMeans Instantiations#1996
Draft
tarang-jain wants to merge 10 commits intorapidsai:mainfrom
Draft
[FEA] Standardize KMeans Instantiations#1996tarang-jain wants to merge 10 commits intorapidsai:mainfrom
tarang-jain wants to merge 10 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tarang-jain
added
breaking
…nto int64-extents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and standardize the kmeans public API types:
int(int32) extent overloads; onlyint64_tremains. This halves the number of template instantiationspredictandfit_predictoutputs useuint32_tlabels (cluster IDs always fit in 32 bits sincen_clustersisint). Removes redundantintandint64_tlabel overloads from balanced kmeans.host_scalar_view<IndexT>tohost_scalar_view<int>throughout — iteration count is always small.These changes are made in the detail templates themselves, so the
.cuwrappers are clean pass-throughs with no temporary buffers or type conversions.