Deinit everything when restarting bt standalone temp sensor#745
Merged
Deinit everything when restarting bt standalone temp sensor#745
Conversation
Without this, you get an error when attempting to reconnect after a restart
peterharperuk
approved these changes
Mar 18, 2026
Contributor
Author
|
@peterharperuk Do you want to absorb this change into your larger PR #743 - or should I merge this separately? |
Contributor
|
It might be quicker if you merge this first. I can make sure this change is picked up in there |
Contributor
Author
|
Sounds good - I'll merge this now then (once the CI is done) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, I get an error when attempting to reconnect after a restart by pressing the S key:
With this fix everything works correctly when starting & stopping using the S key
I'm not sure if everything needs to be deinit'ed, but it is probably safest to deinit all three of these as they are init'ed above