Adding USB-audio feedback and mute command to usb_sound_card.c#53
Open
sh1ura wants to merge 2 commits intoraspberrypi:masterfrom
Open
Adding USB-audio feedback and mute command to usb_sound_card.c#53sh1ura wants to merge 2 commits intoraspberrypi:masterfrom
sh1ura wants to merge 2 commits intoraspberrypi:masterfrom
Conversation
USB-audio feedback (USB AudioStreaming Isochronous Feedback) is indispensable for stable sound playback without clicking noise. I added simple feedback function by checking the vacancy of the buffer. To avoid modifying other sources (such as audio.cpp in pico-extras), number of free buffers is checked in this source code. USB audio also has mute function (mute without changing volume value). I also added this function (in the original source code, it is almost done, so I added just three lines).
Author
|
I noticed something should be improved more, so I will check throughly and redo it. |
Reviewed and tested again. Feedback is properly working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USB-audio feedback (USB Audio Streaming Isochronous Feedback) is indispensable for stable sound playback without clicking noise. I implemented a simple feedback function by monitoring the buffer's vacancy. To avoid modifying other sources (such as audio.cpp in pico-extras), the number of free buffers is checked directly within this source code.
USB audio also includes a mute function (mute without changing the volume value). I enhanced this functionality by adding just three lines of code, as the original source code was almost complete.
Many DIY USB-DAC enthusiasts have been eagerly anticipating the implementation of the feedback function. The modified parts are isolated using switches named USB_FEEDBACK and MUTE_CMD. Please check it out.