Remove duplicated defines from bootrom.h#2621
Merged
kilograham merged 4 commits intodevelopfrom Mar 18, 2026
Merged
Conversation
Contributor
|
i need to see if this affects bootrom builds (and refresh my memory on why this is the way it is) |
kilograham
force-pushed
the
lurch-patch-1
branch
from
429a1ba to
d2dc019
Compare
Contributor
|
(now) fixes #2619 |
lurch
commented
Mar 3, 2026
src/rp2_common/boot_bootrom_headers/include/boot/bootrom_constants.h
Outdated
Show resolved
Hide resolved
lurch
commented
Mar 3, 2026
lurch
commented
Mar 3, 2026
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
kilograham
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2619 for rationale