Flash functions in PICO_NO_FLASH binaries#2759
Open
peterharperuk wants to merge 1 commit intoraspberrypi:developfrom
Open
Flash functions in PICO_NO_FLASH binaries#2759peterharperuk wants to merge 1 commit intoraspberrypi:developfrom
peterharperuk wants to merge 1 commit intoraspberrypi:developfrom
Conversation
Contributor
Author
|
Needed for this raspberrypi/pico-examples#653 |
Contributor
|
Probably would be nicer if It would also need a |
Contributor
Author
Then you would be able to remove these functions by setting PICO_INCLUDE_FLASH_UTILS=0 in flash builds. Which will cause odd behaviour? |
peterharperuk
force-pushed
the
flash_functions_with_pico_no_flash
branch
2 times, most recently
from
e3779f5 to
59aa1e7
Compare
We assume that PICO_NO_FLASH binaries means the device does not have a flash chip. But it's possible that you want a ram binary AND want to mess about with flash, e.g. something that uses the unique flash id. Add PICO_INCLUDE_FLASH_FUNCTIONS which forces some flash functions to be included. Fixes raspberrypi#2796
peterharperuk
force-pushed
the
flash_functions_with_pico_no_flash
branch
from
59aa1e7 to
e3087dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We assume that PICO_NO_FLASH binaries means the device does not have a flash chip. But it's possible that you want a ram binary AND want to mess about with flash, e.g. something that uses the unique flash id.
Add PICO_INCLUDE_FLASH_FUNCTIONS which forces some flash functions to be included.