pioasm: Throw syntax_error for unsupported 'rel' with irq prev/next#2854
Open
gonzalolarralde wants to merge 1 commit intoraspberrypi:developfrom
Open
pioasm: Throw syntax_error for unsupported 'rel' with irq prev/next#2854gonzalolarralde wants to merge 1 commit intoraspberrypi:developfrom
gonzalolarralde wants to merge 1 commit intoraspberrypi:developfrom
Conversation
Replaces error() with throw syntax_error when 'rel' is used with 'irq prev' or 'irq next' instructions in parser.yy. Without this fix the compiler will segfault instead of throw an error when trying to compile the following inputs:
```
.program irq_next_rel
.pio_version 1
irq next set 0 rel
```
```
.program irq_prev_rel
.pio_version 1
irq prev set 0 rel
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces error() with throw syntax_error when
relis used withirq prevorirq nextinstructions in parser.yy. Without this fix the compiler will segfault instead of throw an error when trying to compile the following inputs:Before this fix:
After the fix: