Add justifications for missing PICO_BAZEL_CONFIG and PICO_CMAKE_CONFIG entries#2875
Open
Add justifications for missing PICO_BAZEL_CONFIG and PICO_CMAKE_CONFIG entries#2875
PICO_BAZEL_CONFIG and PICO_CMAKE_CONFIG entries#2875Conversation
…NFIG` entries This means compare_build_systems.py doesn't raise any more warnings
lurch
reviewed
Mar 23, 2026
Comment on lines
+129
to
+130
| # These aren't supported as build flags in CMake either, but they appear | ||
| # as comments which this script can't tell. |
Contributor
There was a problem hiding this comment.
Alternatively, it looks like this simple tweak allows this script to ignore "commented out" PICO_CMAKE_CONFIG options?
--- a/tools/compare_build_systems.py
+++ b/tools/compare_build_systems.py
@@ -187,6 +187,9 @@ def FindKnownOptions(option_pattern_matcher, file_paths):
for p in file_paths:
with open(p, "r") as f:
for line in f:
+ if re.match("\s*#\s*#", line):
+ continue
+
match = re.search(pattern, line)
if not match:
continue
lurch
reviewed
Mar 23, 2026
| # have to write out a bespoke run_binary. | ||
| "PICO_NO_UF2", | ||
| "PICO_NO_COPRO_DIS", | ||
| "PICO_ALLOW_EXAMPLE_KEYS", |
Contributor
There was a problem hiding this comment.
Should there be an explicit TODO: to add a similar option to Bazel?
| "PICO_DEFAULT_BOARD_rp2350", | ||
| "PICO_DEFAULT_BOARD_host", | ||
| # Bazel doesn't provide a way of overriding the defaults for this. | ||
| # TODO: Provide a way to customise these toolchain flags. |
Contributor
There was a problem hiding this comment.
These should be pretty easy. I'll take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add justifications for why
PICO_BAZEL_CONFIGandPICO_CMAKE_CONFIGentries differ - mostly they are configs that only make sense in one or the other, but some added to TODOs to implement in Bazel in the futureThis means compare_build_systems.py doesn't raise any more warnings
Fixes #2868