Skip to content

fix: Add missing block_cipher.c to pico_mbedtls#2883

Open
kripton wants to merge 2 commits intoraspberrypi:developfrom
kripton:fixMbedtlsBlockCipher
Open

fix: Add missing block_cipher.c to pico_mbedtls#2883
kripton wants to merge 2 commits intoraspberrypi:developfrom
kripton:fixMbedtlsBlockCipher

Conversation

@kripton
Copy link
Copy Markdown

@kripton kripton commented Mar 29, 2026

Fixes #2882

It looks like the reference to block_cipher.c was missed in pico_mbedtls.

I did NOT recompile any examples with this changes but the file exists on disk and will do nothing if the relevant #define is not set in mbedtls_config.h

@kripton
Copy link
Copy Markdown
Author

kripton commented Mar 29, 2026

OK, I need to rework this. Merge conflict arose because I did the changes on main but switched the base branch of this PR to develop as instructed

@kripton kripton force-pushed the fixMbedtlsBlockCipher branch from 7ec77c8 to c71a300 Compare March 29, 2026 12:10
@kripton
Copy link
Copy Markdown
Author

kripton commented Mar 29, 2026

Ok, commit updated against latest develop. I also checked https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_mbedtls/mbedtls.BUILD#L8 but it shouldn't be an issue here since a glob pattern is used.

Copy link
Copy Markdown
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think support for this was only added in 3.6.0? In which case we should make an effort to still build with older versions of mbedtls.

@kripton
Copy link
Copy Markdown
Author

kripton commented Mar 30, 2026

I think support for this was only added in 3.6.0? In which case we should make an effort to still build with older versions of mbedtls.

Agreed, that makes sense. I changed the PR accordingly and tested my project (without the workaround described in #2882) compiles fine. However, I have not tested using an older version of mbedtls (<3.6.0)

@kripton kripton requested a review from peterharperuk March 30, 2026 11:32
@lurch lurch added the mbedtls label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants