feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels#165
Conversation
af75cf3 to
5a92e02
Compare
CellSized trait for querying cell dimensions in physical and CSS pixelsCellSized trait for querying cell dimensions in physical and CSS pixels
5a92e02 to
f553cba
Compare
…physical and CSS pixels
f553cba to
8f256fe
Compare
|
hmm, tested with the "minimal" example: the offset bug when zooming in the webgl2 backend has returned... it's unrelated to these changes, as it exhibits the same buggy behavior one main. i'll fix it separately (+ add some form of integration test...) |
fixed it in beamterm - which also translated to simplified mouse handling in ratzilla (-35 loc) |
|
Cool, is this ready for review? |
it is now; and the offset bug was fixed after merging main into the branch. |
There was a problem hiding this comment.
I feel like we should include this trait in either util module or move it under backend
There was a problem hiding this comment.
i'll move it to backend! (util is an option too ofc, but it feels a bit wrong - maybe it's just me).
enabler for properly handling mouse wheel scroll events in #142
revolves around the
CellSizedtrait, implemented by all backends.