Fix sound not disabled anywhere using ``sound'' option.#3
Open
imdjh wants to merge 2 commits intorauchg:masterfrom
Open
Fix sound not disabled anywhere using ``sound'' option.#3imdjh wants to merge 2 commits intorauchg:masterfrom
imdjh wants to merge 2 commits intorauchg:masterfrom
Conversation
When start without GB/GBC ROM provided in ``GBBOOTROM'' / ``GBCBOOTROM'' variable, ``soundMasterEnabled'' variable is set by default. A logic glitch would enable ``soundMasterEnabled'' variable anyway.
Author
|
With this patch, the actual memory taking & CPU ticking are saved. Here's the # Before patch with sound: false
[JavaScript]:
ticks total nonlib name
1891 3.0% 12.4% LazyCompile: *min native math.js:152
1744 2.7% 11.5% LazyCompile: *GameBoyCore.executeIteration /home/djh/bum/letweplay-codes/weplay-emulator/node_modules/gameboy/index.js:5837
1151 1.8% 7.6% LazyCompile: *GameBoyCore.computeAudioChannels /home/djh/bum/letweplay-codes/weplay-emulator/node_modules/gameboy/index.js:5626
1072 1.7% 7.0% KeyedCallMegamorphic: args_count: 2# After patch with sound: false
[JavaScript]:
ticks total nonlib name
12215 4.9% 22.2% LazyCompile: *GameBoyCore.executeIteration /home/djh/bum/letweplay-codes/weplay-emulator/node_modules/gameboy/index.js:5837
7313 2.9% 13.3% KeyedCallMegamorphic: args_count: 2
6657 2.7% 12.1% KeyedCallMegamorphic: args_count: 1 {1} |
Author
|
Hi, rauchg: I found this PR would causing GB emulating freeze randomly. I have no idea why it happenes, but I think the results are the results that it reduced CPU tick in audio part of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When start without GB/GBC ROM provided in
GBBOOTROM/GBCBOOTROMvariable,soundMasterEnabledvariable is set by default.A logic glitch would enable
soundMasterEnabledvariable anyway.