Skip to content

Addressing PR comments #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raux merged 3 commits into from
Feb 23, 2026
Merged

Addressing PR comments #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70a3e0f
Initial plan
Copilot Feb 23, 2026
31d8991
Fix connection test to use /models endpoint instead of chat/completions
Copilot Feb 23, 2026
aac2ecd
Improve model availability check to warn when no models are reported
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,30 +564,38 @@ export function activate(context: vscode.ExtensionContext) {
throw new Error('Invalid URL format. Expected format: host:port/path (e.g., localhost:1234/v1)');
}

const res = await fetch(`http://${testUrl}/chat/completions`, {
method: 'POST',
// First, test basic connectivity using the /models endpoint (lightweight, no model execution)
const modelsRes = await fetch(`http://${testUrl}/models`, {
method: 'GET',
headers: {
'Content-Type': 'application/json',
'Authorization': 'Bearer lm-studio',
},
body: JSON.stringify({
model: testModel,
messages: [{ role: 'user', content: 'Say "connected" in one word.' }],
temperature: 0,
max_tokens: 10,
stream: false,
}),
});

if (!res.ok) {
const text = await res.text().catch(() => '');
throw new Error(`HTTP ${res.status} ${res.statusText}${text ? ` - ${text}` : ''}`);
if (!modelsRes.ok) {
const text = await modelsRes.text().catch(() => '');
throw new Error(`Server not reachable: HTTP ${modelsRes.status} ${modelsRes.statusText}${text ? ` - ${text}` : ''}`);
}

const json: any = await res.json();
const output = json?.choices?.[0]?.message?.content?.trim?.() ?? '';
bonsaiLog('Connection test successful. Response:', output);
panel.webview.postMessage({ command: 'connectionTestResult', success: true, message: `✓ Connected! Model responded: "${output}"` });
const modelsJson: any = await modelsRes.json();
const availableModels = modelsJson?.data?.map((m: any) => m.id) ?? [];

// Check if the specified model is available
let modelStatus: string;
if (availableModels.length === 0) {
modelStatus = `Warning: No models reported by server. Make sure "${testModel}" is loaded.`;
} else if (availableModels.includes(testModel)) {
modelStatus = `Model "${testModel}" is available.`;
} else {
modelStatus = `Warning: Model "${testModel}" not found. Available: ${availableModels.join(', ')}`;
}

bonsaiLog('Connection test successful. Server reachable.', modelStatus);
panel.webview.postMessage({
command: 'connectionTestResult',
success: true,
message: `✓ Connected to LLM server! ${modelStatus}`
});
} catch (err: any) {
bonsaiLog('Connection test failed:', err?.message || err);
panel.webview.postMessage({ command: 'connectionTestResult', success: false, message: `✗ Connection failed: ${err?.message || err}` });
Expand Down
42 changes: 25 additions & 17 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,30 +502,38 @@ async function handleMessage(message: any): Promise<void> {
throw new Error('Invalid URL format. Expected format: host:port/path (e.g., localhost:1234/v1)');
}

const res = await fetch(`http://${testUrl}/chat/completions`, {
method: 'POST',
// First, test basic connectivity using the /models endpoint (lightweight, no model execution)
const modelsRes = await fetch(`http://${testUrl}/models`, {
method: 'GET',
headers: {
'Content-Type': 'application/json',
'Authorization': 'Bearer lm-studio',
},
body: JSON.stringify({
model: testModel,
messages: [{ role: 'user', content: 'Say "connected" in one word.' }],
temperature: 0,
max_tokens: 10,
stream: false,
}),
});

if (!res.ok) {
const text = await res.text().catch(() => '');
throw new Error(`HTTP ${res.status} ${res.statusText}${text ? ` - ${text}` : ''}`);
if (!modelsRes.ok) {
const text = await modelsRes.text().catch(() => '');
throw new Error(`Server not reachable: HTTP ${modelsRes.status} ${modelsRes.statusText}${text ? ` - ${text}` : ''}`);
}

const json: any = await res.json();
const output = json?.choices?.[0]?.message?.content?.trim?.() ?? '';
bonsaiLog('Connection test successful. Response:', output);
broadcast({ command: 'connectionTestResult', success: true, message: `✓ Connected! Model responded: "${output}"` });
const modelsJson: any = await modelsRes.json();
const availableModels = modelsJson?.data?.map((m: any) => m.id) ?? [];

// Check if the specified model is available
let modelStatus: string;
if (availableModels.length === 0) {
modelStatus = `Warning: No models reported by server. Make sure "${testModel}" is loaded.`;
} else if (availableModels.includes(testModel)) {
modelStatus = `Model "${testModel}" is available.`;
} else {
modelStatus = `Warning: Model "${testModel}" not found. Available: ${availableModels.join(', ')}`;
}

bonsaiLog('Connection test successful. Server reachable.', modelStatus);
broadcast({
command: 'connectionTestResult',
success: true,
message: `✓ Connected to LLM server! ${modelStatus}`
});
} catch (err: any) {
bonsaiLog('Connection test failed:', err?.message || err);
broadcast({ command: 'connectionTestResult', success: false, message: `✗ Connection failed: ${err?.message || err}` });
Expand Down