Fixes: Removed diagnostics reset, added keepjumps. Stylua formatting.#16
Open
coreyb-git wants to merge 6 commits intoravibrock:mainfrom
Open
Fixes: Removed diagnostics reset, added keepjumps. Stylua formatting.#16coreyb-git wants to merge 6 commits intoravibrock:mainfrom
coreyb-git wants to merge 6 commits intoravibrock:mainfrom
Conversation
added 3 commits
February 18, 2026 13:05
…mn resizing when width is auto.
…list isn't destroyed. Fix: Removed the unnecessary events, leaving just TextChanged and InsertLeave as the sane, calm, events to update on.
coreyb-git
changed the title
Author
|
I've now added the "keepjumps" command in the function that updates the list of spelling error locations. Without this your plugin was destroying the vim jumplist each time you move the cursor. Also, reduced the events to just TextChanged, and InsertLeave, so that the plugin is calmer, instead of firing on every single little thing. Formatting has been applied across the files, as per conform.nvim and stylua. |
coreyb-git
changed the title
Owner
|
Thanks for the PR Corey! Sorry for taking a while to reply–been busy. Hope to review this and get it merged over the weekend. |
…done using BufReadPost.
Author
|
No problem. I just noticed that my changes to the events meant there was no initial bootstrapping of the signs, so I've added the BufReadPost trigger to fix that. |
…osHold event on the buffer at vim.o.updatetime. Also, forgot to swap-in bufnr at the 2nd instance in the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When signcolumn has an "auto" setting this causes a UI redraw event that resizes the gutter inwards due to there being less icons in the gutter. Next, repopulating the diagnostics causes another UI redraw to resize the gutter back outwards to account for the re-adding of all the spellwarn diagnostics. This is a rapid visual glitch.
Diagnostics doesn't require a reset for NeoVim to automatically remove the entries that are no longer in the newly set diagnostics list of a namespace (at least in NeoVim v12), thus the reset function is unnecessary, and only serves to create visual glitching with every spelling mistake fixed or created when the signcolumn width is "auto".