Skip to content

[Bug] Autoscaler doesn't support TLS #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin85421 merged 3 commits into from
May 30, 2023
Merged

[Bug] Autoscaler doesn't support TLS #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e4903
Add ability to mount volumes in AutoscalerOptions
chrisxstyles May 27, 2023
d9f0b72
fix tests
chrisxstyles May 27, 2023
76b4918
add sample YAML for autoscaler with TLS
chrisxstyles May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions helm-chart/kuberay-operator/crds/ray.io_rayclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed for
enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume within
a container.
properties:
mountPath:
description: Path within the container at which the volume
should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts are
propagated from the host to container and the other way
a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator should
Expand Down
36 changes: 36 additions & 0 deletions helm-chart/kuberay-operator/crds/ray.io_rayjobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed
for enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume
within a container.
properties:
mountPath:
description: Path within the container at which the
volume should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts
are propagated from the host to container and the
other way a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator
Expand Down
36 changes: 36 additions & 0 deletions helm-chart/kuberay-operator/crds/ray.io_rayservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed
for enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume
within a container.
properties:
mountPath:
description: Path within the container at which the
volume should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts
are propagated from the host to container and the
other way a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator
Expand Down
20 changes: 11 additions & 9 deletions ray-operator/apis/ray/v1alpha1/raycluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ type AutoscalerOptions struct {
Env []v1.EnvVar `json:"env,omitempty"`
// Optional list of sources to populate environment variables in the autoscaler container.
EnvFrom []v1.EnvFromSource `json:"envFrom,omitempty"`
// Optional list of volumeMounts. This is needed for enabling TLS for the autoscaler container.
VolumeMounts []v1.VolumeMount `json:"volumeMounts,omitempty"`
// SecurityContext defines the security options the container should be run with.
// If set, the fields of SecurityContext override the equivalent fields of PodSecurityContext.
// More info: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
Expand Down Expand Up @@ -151,15 +153,15 @@ const (
)

// RayCluster is the Schema for the RayClusters API
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:printcolumn:name="desired workers",type=integer,JSONPath=".status.desiredWorkerReplicas",priority=0
//+kubebuilder:printcolumn:name="available workers",type=integer,JSONPath=".status.availableWorkerReplicas",priority=0
//+kubebuilder:printcolumn:name="status",type="string",JSONPath=".status.state",priority=0
//+kubebuilder:printcolumn:name="age",type="date",JSONPath=".metadata.creationTimestamp",priority=0
//+kubebuilder:printcolumn:name="head pod IP",type="string",JSONPath=".status.head.podIP",priority=1
//+kubebuilder:printcolumn:name="head service IP",type="string",JSONPath=".status.head.serviceIP",priority=1
//+genclient
// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="desired workers",type=integer,JSONPath=".status.desiredWorkerReplicas",priority=0
// +kubebuilder:printcolumn:name="available workers",type=integer,JSONPath=".status.availableWorkerReplicas",priority=0
// +kubebuilder:printcolumn:name="status",type="string",JSONPath=".status.state",priority=0
// +kubebuilder:printcolumn:name="age",type="date",JSONPath=".metadata.creationTimestamp",priority=0
// +kubebuilder:printcolumn:name="head pod IP",type="string",JSONPath=".status.head.podIP",priority=1
// +kubebuilder:printcolumn:name="head service IP",type="string",JSONPath=".status.head.serviceIP",priority=1
// +genclient
type RayCluster struct {
// Standard object metadata.
metav1.TypeMeta `json:",inline"`
Expand Down
7 changes: 7 additions & 0 deletions ray-operator/apis/ray/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ray-operator/config/crd/bases/ray.io_rayclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed for
enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume within
a container.
properties:
mountPath:
description: Path within the container at which the volume
should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts are
propagated from the host to container and the other way
a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator should
Expand Down
36 changes: 36 additions & 0 deletions ray-operator/config/crd/bases/ray.io_rayjobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed
for enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume
within a container.
properties:
mountPath:
description: Path within the container at which the
volume should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts
are propagated from the host to container and the
other way a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator
Expand Down
36 changes: 36 additions & 0 deletions ray-operator/config/crd/bases/ray.io_rayservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,42 @@ spec:
- Aggressive
- Conservative
type: string
volumeMounts:
description: Optional list of volumeMounts. This is needed
for enabling TLS for the autoscaler container.
items:
description: VolumeMount describes a mounting of a Volume
within a container.
properties:
mountPath:
description: Path within the container at which the
volume should be mounted. Must not contain ':'.
type: string
mountPropagation:
description: mountPropagation determines how mounts
are propagated from the host to container and the
other way a
type: string
name:
description: This must match the Name of a Volume.
type: string
readOnly:
description: Mounted read-only if true, read-write otherwise
(false or unspecified). Defaults to false.
type: boolean
subPath:
description: Path within the volume from which the container's
volume should be mounted.
type: string
subPathExpr:
description: Expanded path within the volume from which
the container's volume should be mounted.
type: string
required:
- mountPath
- name
type: object
type: array
type: object
enableInTreeAutoscaling:
description: EnableInTreeAutoscaling indicates whether operator
Expand Down
Loading