[Fix] Fail RayService if StepSizePercent exceeds MaxSurgePercent#4663
Open
JiangJiaWei1103 wants to merge 1 commit intoray-project:masterfrom
Open
[Fix] Fail RayService if StepSizePercent exceeds MaxSurgePercent#4663JiangJiaWei1103 wants to merge 1 commit intoray-project:masterfrom
JiangJiaWei1103 wants to merge 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>
JiangJiaWei1103
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
Contributor
Author
|
cc @ryanaoleary @win5923 @machichima to take a look if you have time, thanks! |
machichima
approved these changes
Mar 31, 2026
Contributor
Author
|
Hi @machichima, Thanks for the review, I've observed this e2e failure over the past week (issue), which is not relevant to this PR. I think @rueian is also trying to fix it. I'll take some time to figure out what's going on. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When
StepSizePercentexceedsMaxSurgePercent, the migrated traffic volume was silently capped bytargetCapacitywith no user-facing warning. This PR introduces strict validation, failing the RayService immediately ifStepSizePercentexceedsMaxSurgePercent.Related issue number
Closes #4636
Test Results
The following shows local unit test results:
Checks