Skip to content

[Release / DO NOT MERGE] Update release tests to Python 3.14#63270

Open
pseudo-rnd-thoughts wants to merge 53 commits into
ray-project:masterfrom
pseudo-rnd-thoughts:py3.14-release-testing
Open

[Release / DO NOT MERGE] Update release tests to Python 3.14#63270
pseudo-rnd-thoughts wants to merge 53 commits into
ray-project:masterfrom
pseudo-rnd-thoughts:py3.14-release-testing

Conversation

@pseudo-rnd-thoughts

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented May 11, 2026

Copy link
Copy Markdown
Member

[DO NOT MERGE]

Description

Testing all the release tests with Python 3.14

All nightly core, clusters, data, ml are passing with only a single tune related bug.
Next: serve test, most tests pass though we need to update the anyscale cli's pydantic implementation to be compatible with 3.14

we can't test llm as cuda-tile hasn't got 3.14 tests yet (May 22nd)

elliot-barn and others added 11 commits May 1, 2026 23:26
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Comment thread release/release_tests.yaml Outdated
Comment thread release/release_tests.yaml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python version for various release tests from 3.10 or 3.12 to 3.14. The reviewer identified several critical issues: Python 3.14 is not yet a released version, suggesting a widespread typo, and the change introduces incompatibilities with existing Python 3.12 lockfiles and specialized Docker images used in the testing infrastructure.

Comment thread release/release_tests.yaml
Comment thread release/release_tests.yaml Outdated
Comment thread release/release_tests.yaml Outdated
Comment thread release/release_tests.yaml
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts requested a review from a team as a code owner May 11, 2026 17:04
Mark Towers and others added 3 commits May 11, 2026 18:17
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@ray-gardener ray-gardener Bot added core Issues that should be addressed in Ray Core devprod release-test release test labels May 11, 2026

@aslonnie aslonnie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(skipping review on draft pr)

@aslonnie aslonnie requested a review from elliot-barn May 11, 2026 19:40
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@elliot-barn elliot-barn requested a review from a team as a code owner May 12, 2026 17:59
pseudo-rnd-thoughts and others added 3 commits May 15, 2026 12:44
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Comment thread ci/raydepsets/configs/ray_torch.depsets.yaml Outdated
Comment thread ci/raydepsets/configs/ray_torch.depsets.yaml
Mark Towers added 6 commits May 21, 2026 13:15
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Comment thread docker/ray-torch/torch-requirements.txt
Mark Towers added 3 commits May 22, 2026 09:30
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts requested a review from a team as a code owner May 22, 2026 08:51
Comment thread ci/ray_ci/oss_config.yaml
Mark Towers added 7 commits May 22, 2026 12:06
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Comment thread .buildkite/release/build.rayci.yml
Comment thread docker/ray-llm/cuda.wanda.yaml
Signed-off-by: Mark Towers <mark@anyscale.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.

Comment thread .buildkite/build.rayci.yml
# syntax=docker/dockerfile:1.3-labs

ARG BASE_IMAGE
ARG FULL_BASE_IMAGE=rayproject/ray:nightly"$BASE_IMAGE"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile ARG default contains literal quote characters

Low Severity

The default value for FULL_BASE_IMAGE includes literal double-quote characters around $BASE_IMAGE, producing a malformed image name like rayproject/ray:nightly"value". While this default is always overridden by the wanda build args, the fallback value is syntactically incorrect and could cause confusing failures if someone builds this Dockerfile standalone.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.

Mark Towers added 2 commits May 25, 2026 14:29
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants