[Release / DO NOT MERGE] Update release tests to Python 3.14#63270
[Release / DO NOT MERGE] Update release tests to Python 3.14#63270pseudo-rnd-thoughts wants to merge 53 commits into
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Python version for various release tests from 3.10 or 3.12 to 3.14. The reviewer identified several critical issues: Python 3.14 is not yet a released version, suggesting a widespread typo, and the change introduces incompatibilities with existing Python 3.12 lockfiles and specialized Docker images used in the testing infrastructure.
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
aslonnie
left a comment
There was a problem hiding this comment.
(skipping review on draft pr)
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…14-release-testing
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.
| # syntax=docker/dockerfile:1.3-labs | ||
|
|
||
| ARG BASE_IMAGE | ||
| ARG FULL_BASE_IMAGE=rayproject/ray:nightly"$BASE_IMAGE" |
There was a problem hiding this comment.
Dockerfile ARG default contains literal quote characters
Low Severity
The default value for FULL_BASE_IMAGE includes literal double-quote characters around $BASE_IMAGE, producing a malformed image name like rayproject/ray:nightly"value". While this default is always overridden by the wanda build args, the fallback value is syntactically incorrect and could cause confusing failures if someone builds this Dockerfile standalone.
Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>


[DO NOT MERGE]
Description
Testing all the release tests with Python 3.14
All nightly core, clusters, data, ml are passing with only a single
tunerelated bug.Next: serve test, most tests pass though we need to update the anyscale cli's pydantic implementation to be compatible with 3.14
we can't test llm as cuda-tile hasn't got 3.14 tests yet (May 22nd)