Skip to content

Fix GuiSlider jumping to mouse position on click #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
grerfou wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix GuiSlider jumping to mouse position on click #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/raygui.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3318,6 +3318,9 @@ int GuiSlider(Rectangle bounds, const char *textLeft, const char *textRight, flo
Rectangle slider = { bounds.x, bounds.y + GuiGetStyle(SLIDER, BORDER_WIDTH) + GuiGetStyle(SLIDER, SLIDER_PADDING),
0, bounds.height - 2*GuiGetStyle(SLIDER, BORDER_WIDTH) - 2*GuiGetStyle(SLIDER, SLIDER_PADDING) };

// Static variable to store drag offset
static float dragOffsetX = 0.0f;

// Update control
//--------------------------------------------------------------------
if ((state != STATE_DISABLED) && !guiLocked)
Expand All @@ -3332,7 +3335,7 @@ int GuiSlider(Rectangle bounds, const char *textLeft, const char *textRight, flo
{
state = STATE_PRESSED;
// Get equivalent value and slider position from mousePosition.x
*value = (maxValue - minValue)*((mousePoint.x - bounds.x - sliderWidth/2)/(bounds.width - sliderWidth)) + minValue;
*value = (maxValue - minValue)*((mousePoint.x - dragOffsetX - bounds.x - sliderWidth/2)/(bounds.width - sliderWidth)) + minValue;
}
}
else
Expand All @@ -3346,14 +3349,11 @@ int GuiSlider(Rectangle bounds, const char *textLeft, const char *textRight, flo
if (IsMouseButtonDown(MOUSE_LEFT_BUTTON))
{
state = STATE_PRESSED;
float currentSliderPos = bounds.x + sliderWidth/2 + (((*value - minValue)/(maxValue - minValue))*(bounds.width - sliderWidth));
dragOffsetX = mousePoint.x - currentSliderPos;

guiControlExclusiveMode = true;
guiControlExclusiveRec = bounds; // Store bounds as an identifier when dragging starts

if (!CheckCollisionPointRec(mousePoint, slider))
{
// Get equivalent value and slider position from mousePosition.x
*value = (maxValue - minValue)*((mousePoint.x - bounds.x - sliderWidth/2)/(bounds.width - sliderWidth)) + minValue;
}
}
else state = STATE_FOCUSED;
}
Expand Down