Skip to content

fix zig syntax errors (0.11.0) in examples, and make it install executables correctly#3395

Merged
raysan5 merged 1 commit into
raysan5:masterfrom
purple4pur:fix-zig-in-examples
Oct 13, 2023
Merged

fix zig syntax errors (0.11.0) in examples, and make it install executables correctly#3395
raysan5 merged 1 commit into
raysan5:masterfrom
purple4pur:fix-zig-in-examples

Conversation

@purple4pur

Copy link
Copy Markdown
Contributor

Related: #3386 #3393

Much appreciated @Not-Nik @star-tek-mb !

@raysan5

raysan5 commented Oct 10, 2023

Copy link
Copy Markdown
Owner

@Not-Nik @star-tek-mb please, could you review this PR?

@purple4pur purple4pur changed the title fix zig syntax errors (0.11.0) in examples, and make it install executables crrectly fix zig syntax errors (0.11.0) in examples, and make it install executables correctly Oct 10, 2023
@star-tek-mb

Copy link
Copy Markdown
Contributor

I don't know honestly.. I think we should either revert all recent changes. Either make a complex change with one top-level build.zig file. Because building from different directories - breaks everything.

I tried to build from top level and from src and from examples directory. It's hacking. I'm only using top level build.zig for package manager. And I'm not using examples and object files from src. So, we need better build design for using raylib with Zig, and using Zig toolchain to build .c files with raylib.

I can look at it, but on weekends.

@Not-Nik

Not-Nik commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

This PR only updates the example build file to Zig 0.11. We can discuss further design changes elsewhere.

@raysan5 raysan5 merged commit 4981acb into raysan5:master Oct 13, 2023
@raysan5

raysan5 commented Oct 13, 2023

Copy link
Copy Markdown
Owner

@purple4pur @Not-Nik thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants