fix: pin responses encrypted content affinity#161
Merged
Conversation
shudonglin
commented
Jun 27, 2026
shudonglin
left a comment
Author
There was a problem hiding this comment.
Post-merge review note from the gateway release pass.
Reviewed as part of the production deployment verification. CI passed before merge, the Bifrost image was built and deployed successfully, production Terraform converged, live Cloud Run traffic is on the merged Bifrost image tag, and post-deploy smoke/log checks passed. No follow-up blocker found in this PR during release verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invalid_encrypted_contenterrorsprevious_response_idand encrypted-content affinity to the selected keyRoot cause
Azure Responses encrypted content is bound to the Azure deployment/key that produced it. Bifrost could rotate or fall back to a different Azure key on a later Responses request, then Azure rejected the continuation with
invalid_encrypted_contentbecause that key could not decrypt the state.Validation
go test ./...incore/gofmtgit diff --checkNotes
The cache uses the configured Bifrost KV store. In a multi-instance deployment without KV sync, affinity can still miss when a continuation lands on another instance. The paired infra PR enables Cloud Run session affinity for prod Bifrost to reduce that risk, and a durable/shared KV backend would be the stronger long-term fix.